Fix systemVM template name in metadata file

[Pearl1594]

Description

This PR fixes the issue observed during upgrades, wherein, when a SystemVM template is already registered prior upgrade, the auto-upgrade path still gets invoked - which it shouldn't. The reason for this behavior is the incorrect name of the systemVM template placed in the metadata.ini file, which is used as an input during the upgrade process to identify the template names, checksums, download path, etc. In case of noredist builds, this would cause unnecessary re-registration; in case of non noredist builds, this could lead to the upgrade failing, as it fails to identify the registered template and invokes the auto-upgrade logic - which would fail(expected) due to the absence of the template files.

For ex, a snippet of the metadata.ini file (for KVM SystemVM template details)

...
[kvm]
templatename = systemvm-kvm-4.16 <--- incorrect template name (should be systemvm-kvm-4.16.0)
checksum = 2f3747a597396d4ee6a2605648808d1a
downloadurl = https://download.cloudstack.org/systemvm/4.16/systemvmtemplate-4.16.0-kvm.qcow2.bz2
filename = systemvmtemplate-4.16.0-kvm.qcow2.bz2
...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Upgraded the env from 4.15.2 to 4.16, by first registering the systemVM template - upgrade successful & doesn't re-register the template as template is found to be already present.

Pos Fix, the snippet of metadata.ini file looks as follows:

...
[kvm]
templatename = systemvm-kvm-4.16.0
checksum = 2f3747a597396d4ee6a2605648808d1a
downloadurl = https://download.cloudstack.org/systemvm/4.16/systemvmtemplate-4.16.0-kvm.qcow2.bz2
filename = systemvmtemplate-4.16.0-kvm.qcow2.bz2
...

[vladimirpetrov]

@blueorangutan package

[blueorangutan]

@vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[rohityadavcloud]

@Pearl1594 @vladimirpetrov I suppose we'll need to do oss (or non- noredist) packages build, or @GutoVeronezi can you help review/test this?

[DaanHoogland]

code looks good and makes functional sense, but a security update might force us to issue a tiny number for a new template, i.e. 4.16.1.1
Do we cater for such a scenario?

[Pearl1594]

@DaanHoogland It doesn't currently the naming convention considered is systemvm--x.y.z
I wasn't actually aware that we do have security updates where in the version is incremented as you mentioned - 4.16.x.y - however, does the systemvm template registration naming convention change? i.e., do we register the template with the name systemvm-kvm-4.16.1.1 or it continues to be systemvm-kvm-4.16.1 ?

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1598

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GutoVeronezi]

@Pearl1594 @vladimirpetrov I suppose we'll need to do oss (or non- noredist) packages build, or @GutoVeronezi can you help review/test this?

I will do some testing and return with the results.

[vladimirpetrov]

LGTM based on manual testing, tested with regular and oss build.

[GutoVeronezi]

LGTM

I builded the packages without noredis, rolled back my lab to 4.15, seeded systemvm-template-4.16 and then upgraded the lab with 4.16. All worked as expected.

[nvazquez]

Thanks @GutoVeronezi @vladimirpetrov @rhtyd @DaanHoogland, merging

[blueorangutan]

Trillian test result (tid-2454)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31482 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5598-t2454-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File