Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cks: refactor code to be architecture agnostic #5629

Merged
merged 2 commits into from Oct 29, 2021
Merged

cks: refactor code to be architecture agnostic #5629

merged 2 commits into from Oct 29, 2021

Conversation

rohityadavcloud
Copy link
Member

This makes the CKS setup/install/upgrades architecture agnostic and
works on both amd64 and arm64 platforms.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Tested with:
AMD64 cks iso: http://download.cloudstack.org/cks/
ARM64 cks iso: https://dl.yadav.cloud/rpi-templates/cks/

@rohityadavcloud
cks: refactor code to be architecture agnostic
25c379c 
This makes the CKS setup/install/upgrades architecture agnostic and
works on both amd64 and arm64 platforms.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@rohityadavcloud rohityadavcloud added this to the 4.16.1.0 milestone Oct 26, 2021
shwstppr
shwstppr approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, smoke tests should cover them amd64

@blueorangutan
Copy link

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1618

@shwstppr
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1622

@rohityadavcloud
Copy link
Member Author

@blueorangutan test

1 similar comment
@rohityadavcloud
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-2477)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40451 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5629-t2477-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_invalid_upgrade_kubernetes_cluster Failure 3610.99 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 3610.23 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 43.11 test_kubernetes_clusters.py

@rohityadavcloud
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-2481)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32640 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5629-t2481-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_invalid_upgrade_kubernetes_cluster Failure 0.01 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.01 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py

@rohityadavcloud
Copy link
Member Author

Doesn't work for some reason.

@rohityadavcloud rohityadavcloud removed this from the 4.16.1.0 milestone Oct 28, 2021
@shwstppr
fix
7b73b0c 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr reopened this Oct 28, 2021
@shwstppr
Copy link
Contributor

shwstppr commented Oct 28, 2021 •
edited

@rhtyd made change to take wildcard outside quotes, it should work now 🤞

@blueorangutan package

@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1629

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1630

@rohityadavcloud
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-2486)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36153 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5629-t2486-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@rohityadavcloud rohityadavcloud added this to the 4.16.0.0 milestone Oct 29, 2021
@nvazquez nvazquez merged commit cb67da5 into apache:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@davidjumani davidjumani Awaiting requested review from davidjumani

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees
No one assigned
Labels
component:cks component:upgrade Severity:Critical Critical bug type:bug
Projects
None yet
Milestone
4.16.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rohityadavcloud @blueorangutan @shwstppr @nvazquez