New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6: fix deploy vm issue in ipv6-only networks without VR #5648
IPv6: fix deploy vm issue in ipv6-only networks without VR #5648
Conversation
@blueorangutan package |
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1651 |
@blueorangutan test matrix |
@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests |
Trillian test result (tid-2503)
|
Trillian test result (tid-2504)
|
Trillian test result (tid-2505)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @weizhouapache.
+1 on Daan's suggestion on extracting those lines into a method.
Code LGTM.
Description
This PR fixes #5640 partially.
Ipv6-only shared network with offering "Quickcloud with no services" works with this PR.
Ipv6-only shared network with other offerings, which require VR, still does not work, as VR cannot start.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?