Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Deploy VM with params from the template, iso, network pages #5653

Merged

Conversation

utchoang
Copy link

@utchoang utchoang commented Nov 2, 2021

Description

This PR fixes #5639

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
Copy link
Author

utchoang commented Nov 2, 2021

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-802)

@rohityadavcloud
Copy link
Member

I think the specific parameter should be passed to the url and be picked up by the form.

@utchoang
Copy link
Author

utchoang commented Nov 3, 2021

@rhtyd Will now pass the template id, network id on the URL, and will auto-select it on the form.

@rohityadavcloud rohityadavcloud changed the base branch from main to 4.16 November 15, 2021 10:15
@rohityadavcloud rohityadavcloud added this to the 4.16.1.0 milestone Nov 15, 2021
@rohityadavcloud
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@rohityadavcloud rohityadavcloud requested review from shwstppr and Pearl1594 and removed request for shwstppr November 18, 2021 08:23
@blueorangutan
Copy link

UI build: ✖️
(SL-JID-835)

@sureshanaparti
Copy link
Contributor

@blueorangutan ui

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs testing

@shwstppr
Copy link
Contributor

@blueorangutan ui

1 similar comment
@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-967)

@rohityadavcloud
Copy link
Member

@blueorangutan ui

1 similar comment
@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✖️
(SL-JID-992)

@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-996)

@sureshanaparti
Copy link
Contributor

Verified deploy VM from template and network. LGTM.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok. thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[UI] feature request: deploy vm with param from previous page
6 participants