-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow templates & ISOs from IPv6 host address. #5826
Conversation
@blueorangutan package |
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2101 |
@blueorangutan package |
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
db9672f
to
d22cc5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, are we sure we covered all bases with repect to ipv6?
That code is 10 years old, in "another era" where there was not much IPv6 support. @DaanHoogland It is important to note that it could fail to register templates/ISOs from repositories with IPv6 addresses only, in the scenarios where SSVMs do not have an IPv6 address (might be the majority of cases, I don't know who configures or not SystemVMs with IPv6). With that said, I still prefer to have an exception such as To put some context. The reported issue happened in a test-env where Java was configured to prefer IPv6 over IPv4 |
Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2110 |
@blueorangutan package |
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 2113 |
@blueorangutan package |
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2116 |
@blueorangutan test |
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Hi @GabrielBrascher Can you rebase/test templates & ISOs registration (and VM deploy) with 4.16 if this is good in 4.16.1. Thanks. |
d22cc5d
to
f96415e
Compare
@sureshanaparti sounds good. Rebased branch to |
thanks @GabrielBrascher |
@blueorangutan package |
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2123 |
@blueorangutan test |
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-2808)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GabrielBrascher will it make sense to skip IPv6 check only for direct download templates. For normal templates with IPv6 hosts it may still not work on SSVM?
I have same questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe run a quick test @weizhouapache @shwstppr with this PR and http://download.cloudstack.org/ which has AAAA/ipv6 record (2a00:f10:121:400:403:9cff:fe00:37f)? |
@shwstppr good point. |
Hi @GabrielBrascher Can you update the changes as appropriate (skip IPv6 check for direct download templates now, and re-visit the normal templates with SSVM's IPv6 address check later ?) |
Hi @GabrielBrascher Can you confirm if these changes are addressed in this PR. Thanks. |
@GabrielBrascher doing something like following works,
|
@sureshanaparti @shwstppr sorry for the delay here, got a bit stuck with other tasks. @shwstppr thanks for the test, if you want to cherry-pick/create new PR addressing it would be nice as well. |
Thanks for the update @GabrielBrascher I've created another PR #5900 extending your work and @shwstppr suggestions. Closing this one. |
Description
This PR removes a conditional in com.cloud.utils.UriUtils.validateUrl(java.lang.String, java.lang.String).
I don't see reasons to block IPv6 addresses when registering templates & ISOs.
Tested and the whole CloudStack template registration works fine when using IPv6 addresses (both on management node & template repository).
Please let me know if there are any know issues that justify blocking IPv6 addresses.
I've tested on a 4.16.0.0 environment, however, the PR's base branch is main.
I can rebase it for
4.16.1.0
if that sounds good.Fixes: #3047
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?