Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: show account configure limits tab for domain-admin #5858

Merged
merged 1 commit into from Jan 13, 2022
Merged

ui: show account configure limits tab for domain-admin #5858

merged 1 commit into from Jan 13, 2022

Conversation

shwstppr
Copy link
Contributor

Description

Fixes #5676

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@shwstppr
ui: show account configure limits tab for domain-admin
e620641 
Fixes apache#5676

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr mentioned this pull request Jan 13, 2022
Closed
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5858 (SL-JID-1010)

@weizhouapache weizhouapache changed the base branch from main to 4.16 January 13, 2022 11:06
@weizhouapache
Copy link
Member

@blueorangutan ui

@weizhouapache weizhouapache added this to the 4.16.1.0 milestone Jan 13, 2022
@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5858 (SL-JID-1011)

@shwstppr shwstppr marked this pull request as ready for review January 13, 2022 11:19
DaanHoogland
DaanHoogland approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tested and reviewed

sureshanaparti
sureshanaparti approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland merged commit c86b98e into apache:4.16 Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@utchoang utchoang Awaiting requested review from utchoang

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Apache CloudStack 4.16.1
Status: Done
Milestone
4.16.1.0
Development

Successfully merging this pull request may close these issues.

Domain Admin can't configure Limits for a regular User Account in the same domain
5 participants
@shwstppr @blueorangutan @weizhouapache @DaanHoogland @sureshanaparti