Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve memory for host #6809

Open
wants to merge 2 commits into
base: 4.19
Choose a base branch
from
Open

Reserve memory for host #6809

wants to merge 2 commits into from

Conversation

soreana
Copy link
Member

@soreana soreana commented Oct 6, 2022

Description

This pr is a follow up to the #4259 quoted the following from the pr:

By default cloudstack reserves 1Gb of RAM in hosts
using _dom0_memory field. Add a global setting
"host.reserved.mem.mb" which can used to either
increase or decrese the amount of memory which can be reserved

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

Please refer to the original pr at #4259

@soreana soreana force-pushed the host-reserve-memory branch 2 times, most recently from fe87621 to 123b056 Compare October 6, 2022 14:25
@soreana soreana marked this pull request as ready for review October 6, 2022 14:28
@soreana
Copy link
Member Author

soreana commented Oct 6, 2022

@blueorangutan package

@blueorangutan
Copy link

@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4364

@soreana
Copy link
Member Author

soreana commented Oct 7, 2022

@blueorangutan package

@blueorangutan
Copy link

@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4369

@soreana
Copy link
Member Author

soreana commented Oct 7, 2022

@blueorangutan package

@blueorangutan
Copy link

@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4370

@rohityadavcloud
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-5082)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40461 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6809-t5082-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 563.98 test_kubernetes_clusters.py

@soreana
Copy link
Member Author

soreana commented Oct 10, 2022

@DaanHoogland Can I also have this one on 4.18, please ? :)

@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Oct 11, 2022
@DaanHoogland
Copy link
Contributor

@DaanHoogland Can I also have this one on 4.18, please ? :)

marked for 4.18 @soreana

@acs-robot
Copy link
Collaborator

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6809 (SL-JID-2503)

@acs-robot
Copy link
Collaborator

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@benj-n
Copy link
Contributor

benj-n commented Jun 27, 2024

@soreana I force pushed the rebase on 4.19 in Leaseweb:host-reserve-memory but I think as you're the owner of the PR, only you can update the base branch for this PR.

@sureshanaparti sureshanaparti changed the base branch from main to 4.19 June 27, 2024 05:45
@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10155

@sureshanaparti
Copy link
Contributor

@benj-n can check/fix the build error

[INFO] --- maven-checkstyle-plugin:3.1.0:check (cloudstack-checkstyle) @ cloud-server ---
/BUILD/cloudstack-4.19.1.0-SNAPSHOT/server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:2424:5: unexpected token: private
/BUILD/cloudstack-4.19.1.0-SNAPSHOT/server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:2425:15: unexpected token: String

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (cloudstack-checkstyle) on project cloud-server: Failed during checkstyle configuration: Exception was thrown while processing /BUILD/cloudstack-4.19.1.0-SNAPSHOT/server/src/main/java/com/cloud/resource/ResourceManagerImpl.java: MismatchedTokenException occurred while parsing file /BUILD/cloudstack-4.19.1.0-SNAPSHOT/server/src/main/java/com/cloud/resource/ResourceManagerImpl.java. expecting EOF, found 'DetailVO' -> [Help 1]

@benj-n
Copy link
Contributor

benj-n commented Jun 27, 2024

@blueorangutan package

@blueorangutan
Copy link

@benj-n a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10180

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10183

@sureshanaparti
Copy link
Contributor

@benj-n still see build errors

10:37:18 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project cloud-server: Compilation failure
10:37:18 [ERROR] /BUILD/cloudstack-4.19.1.0-SNAPSHOT/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:[7806,127] error: cannot find symbol
10:37:18 [ERROR]   symbol:   variable AllowNonRFC1918CompliantIPs
10:37:18 [ERROR]   location: class ConfigurationManagerImpl

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland DaanHoogland modified the milestones: 4.20.0.0, 4.19.2.0 Jul 1, 2024
Sina Kashipazha and others added 2 commits July 4, 2024 16:01
@benj-n
Reserve memory for host
605b8f7 
By default cloudstack reserves 1Gb of RAM in hosts
using _dom0_memory field. Add a global setting
"host.reserved.mem.mb" which can used to either
increase or decrese the amount of memory which can be reserved
@benj-n
Fix unclosed curly brace
71da43b
@benj-n
Copy link
Contributor

benj-n commented Jul 4, 2024

@blueorangutan package

@blueorangutan
Copy link

@benj-n a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

@GutoVeronezi GutoVeronezi Awaiting requested review from GutoVeronezi

@wido wido Awaiting requested review from wido

Assignees

@soreana soreana

@vladimirpetrov vladimirpetrov

Labels
component:agent component:api component:backup component:build component:compute component:integration component:kvm component:orchestration component:storage status:waiting-for-author
Projects
None yet
Milestone
4.19.2.0
Development

Successfully merging this pull request may close these issues.

None yet