revert cleanup of test_acl_sharenetworks #7033

DaanHoogland · 2022-12-30T08:29:10Z

Description

This PR reverts changes that broke the gh action for test_acl_sharednetworks.py

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

test/integration/component/test_acl_sharednetwork.py

codecov · 2022-12-30T10:57:56Z

Codecov Report

Merging #7033 (29818d9) into main (d5f0100) will increase coverage by 1.17%.
The diff coverage is 16.21%.

@@             Coverage Diff              @@
##               main    #7033      +/-   ##
============================================
+ Coverage     10.36%   11.53%   +1.17%     
- Complexity     6630     7517     +887     
============================================
  Files          2453     2494      +41     
  Lines        242386   246787    +4401     
  Branches      37928    38533     +605     
============================================
+ Hits          25120    28476    +3356     
- Misses       214158   214631     +473     
- Partials       3108     3680     +572

Impacted Files	Coverage Δ
...estration/service/NetworkOrchestrationService.java	`100.00% <ø> (ø)`
...pi/src/main/java/com/cloud/alert/AlertManager.java	`100.00% <ø> (ø)`
...va/com/cloud/deploy/DeploymentPlanningManager.java	`100.00% <ø> (ø)`
...n/java/com/cloud/vm/VirtualMachineProfileImpl.java	`36.44% <0.00%> (-0.70%)`	⬇️
...java/com/cloud/agent/manager/AgentManagerImpl.java	`4.94% <0.00%> (+4.94%)`	⬆️
...k/engine/cloud/entity/api/VMEntityManagerImpl.java	`0.00% <0.00%> (ø)`
...ine/cloud/entity/api/VirtualMachineEntityImpl.java	`0.00% <0.00%> (ø)`
...stack/engine/orchestration/VolumeOrchestrator.java	`0.00% <0.00%> (ø)`
...n/java/com/cloud/capacity/dao/CapacityDaoImpl.java	`3.24% <0.00%> (-0.13%)`	⬇️
.../cloud/network/as/dao/AutoScaleVmGroupDaoImpl.java	`0.00% <0.00%> (ø)`
... and 383 more