Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine/orchestration: enable unit tests and fix errors #7034

Conversation

weizhouapache
Copy link
Member

Description

The unit tests in engine/orchestration module are skipped for now.

This PR enables the unit tests and fixes the errors with the unit tests.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5138

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@DaanHoogland
Copy link
Contributor

@weizhouapache do you feel this has been tested enough with packaging and the github actions?

@weizhouapache
Copy link
Member Author

@weizhouapache do you feel this has been tested enough with packaging and the github actions?

@DaanHoogland
yeah, I think so.
unit tests might be skipped in some packaging jobs or CI checks, but most of them should build cloudstack with unit tests.

@rohityadavcloud rohityadavcloud added this to the 4.18.0.0 milestone Dec 30, 2022
@rohityadavcloud
Copy link
Member

Packaging has passed and the maven build Github Action, so unit tests are passing. Changes are only in unit tests so integration tests are n't required.

@rohityadavcloud rohityadavcloud merged commit 0bedb58 into apache:main Dec 30, 2022
@weizhouapache weizhouapache deleted the 4.18-fix-engine-orchestration-unit-tests branch January 5, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants