New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine/orchestration: enable unit tests and fix errors #7034
engine/orchestration: enable unit tests and fix errors #7034
Conversation
@blueorangutan package |
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5138 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
@weizhouapache do you feel this has been tested enough with packaging and the github actions? |
@DaanHoogland |
Packaging has passed and the maven build Github Action, so unit tests are passing. Changes are only in unit tests so integration tests are n't required. |
Description
The unit tests in engine/orchestration module are skipped for now.
This PR enables the unit tests and fixes the errors with the unit tests.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?