New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PassphraseVO to use String instead of byte[] to support Encrypt annotation #7302
Move PassphraseVO to use String instead of byte[] to support Encrypt annotation #7302
Conversation
@blueorangutan package |
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
SonarCloud Quality Gate failed. |
Codecov Report
@@ Coverage Diff @@
## main #7302 +/- ##
=========================================
Coverage 12.69% 12.69%
- Complexity 8655 8657 +2
=========================================
Files 2716 2716
Lines 256117 256117
Branches 39927 39928 +1
=========================================
+ Hits 32503 32513 +10
+ Misses 219482 219469 -13
- Partials 4132 4135 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@blueorangutan test rocky8 kvm-rocky8 keepEnv |
@weizhouapache a Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests |
Thanks @weizhouapache - need to remember to confirm also that we included the change for passphrase column size larger than 64. |
@mlsorensen thanks for the reminder Just checked it, the size has been changed to 255 in #7003 . it should be good
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@blueorangutan test matrix |
@borisstoyanov a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests |
Trillian test result (tid-6248)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on manual testing. I tested the passphrase length, decrypting it and basic CRUD operations - all looks fine.
Trillian test result (tid-6252)
|
Trillian test result (tid-6254)
|
Trillian test result (tid-6253)
|
Is this ready for merging or needs further review/testing - @borisstoyanov @vladimirpetrov @weizhouapache ? |
Description
This PR fixes #7299
This is proposed by @mlsorensen
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?