guarantee MAC uniqueness

[DaanHoogland]

Description

This PR makes sure a new MAC is unique by

• using zone DB ID as default ZoneMacIdentifyer
• checking if the mac exists in the nics table
  if the mac exists a new one will be generated untill a free one is found.

This is a fix that will not generate duplicate MAC addresses in the future and prevent duplicates if prior versions generated randon MACs before.

Fixes: #7633

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

The testing of this feature is dependend on randomly generated MAC addresses that are in the way when generating logicly deterministic. Any testing suggestions are appreciated.

[codecov]

Codecov Report

Merging #7634 (016c550) into 4.18 (1aa4f80) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.18    #7634      +/-   ##
============================================
+ Coverage     12.98%   13.02%   +0.03%     
- Complexity     8989     9028      +39     
============================================
  Files          2716     2719       +3     
  Lines        256343   256846     +503     
  Branches      39981    40051      +70     
============================================
+ Hits          33291    33448     +157     
- Misses       218886   219211     +325     
- Partials       4166     4187      +21     

Impacted Files	Coverage Δ
...ter/entity/api/db/dao/EngineDataCenterDaoImpl.java	0.00% <ø> (ø)
.../src/main/java/com/cloud/dc/dao/DataCenterDao.java	0.00% <ø> (ø)
.../main/java/com/cloud/dc/dao/DataCenterDaoImpl.java	18.81% <ø> (+0.63%)	⬆️
...ain/java/com/cloud/network/dao/NetworkDaoImpl.java	3.21% <ø> (+<0.01%)	⬆️
...ema/src/main/java/com/cloud/vm/dao/NicDaoImpl.java	23.50% <ø> (+0.11%)	⬆️
...a/com/cloud/hypervisor/hyperv/guru/HypervGuru.java	0.00% <0.00%> (ø)
...com/cloud/hypervisor/guru/VmwareVmImplementer.java	0.00% <0.00%> (ø)
...a/com/cloud/network/vm/NetScalerVMManagerImpl.java	0.00% <0.00%> (ø)
.../main/java/com/cloud/network/NetworkModelImpl.java	11.11% <0.00%> (-0.05%)	⬇️
...ava/com/cloud/network/guru/ControlNetworkGuru.java	4.81% <0.00%> (ø)

... and 41 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[weizhouapache]

code lgtm

@DaanHoogland
Ihink the title needs to be updated

[BryanMLima]

LGTM. I just made some suggestions over some typos around the code.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6417

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[rohityadavcloud]

ping @shwstppr @nvazquez for review
@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6492

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7098)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42717 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7634-t7098-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	78.56	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	55.37	test_vm_life_cycle.py