New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils: fix check for metalink url #7636
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## 4.18 #7636 +/- ##
=========================================
Coverage 12.98% 12.99%
- Complexity 8984 8991 +7
=========================================
Files 2716 2716
Lines 256329 256343 +14
Branches 39974 39981 +7
=========================================
+ Hits 33275 33301 +26
+ Misses 218892 218875 -17
- Partials 4162 4167 +5 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@blueorangutan package |
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6241 |
@blueorangutan test |
@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
[SF] Trillian test result (tid-6758)
|
code looks good @shwstppr, but what does this fix? |
Code |
haha, no issue no description. why is this? |
To fix code. I guess most developers should get the fact that the condition that has been changed was originally incorrect. |
Merging based on tests and 2xLGTM |
Yes, they should but we are not all developers here and some might want to test this and want to know what behaviourt to look for. |
Description
Fixes condition
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?