Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix listLoadBalancerRuleInstances api call #7892

Merged
merged 3 commits into from Sep 9, 2023
Merged

Fix listLoadBalancerRuleInstances api call #7892

merged 3 commits into from Sep 9, 2023

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Aug 22, 2023 •
edited

Description

This PR fixes listLoadBalancerRuleInstances api call which fails when there are no instances. Fixed by returning an empty list when input to the dao method is empty.
This issue was introduced in this PR: https://github.com/apache/cloudstack/pull/7153/files

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@vishesh92 vishesh92 self-assigned this Aug 22, 2023
@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@vishesh92 vishesh92 force-pushed the fix-list-load-balancer-rule-instances branch from b363489 to 4bb83bb Compare August 22, 2023 09:44
@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@vishesh92 vishesh92 force-pushed the fix-list-load-balancer-rule-instances branch from 4bb83bb to 7947929 Compare August 22, 2023 10:00
weizhouapache
weizhouapache approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6853

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland
DaanHoogland approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6860

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@rohityadavcloud rohityadavcloud added this to the 4.19.0.0 milestone Aug 23, 2023
@blueorangutan
Copy link

[SF] Trillian test result (tid-7521)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39832 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7892-t7521-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestVmAutoScaling>:setup Error 0.00 test_vm_autoscaling.py
test_02_cancel_host_maintenace_with_migration_jobs Error 0.38 test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure Error 0.39 test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected Failure 56.68 test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected Failure 20.40 test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected Failure 32.44 test_host_maintenance.py

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-7529)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42933 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7892-t7529-kvm-centos7.zip
Smoke tests completed. 109 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_07_deploy_kubernetes_ha_cluster Failure 3615.21 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 101.09 test_kubernetes_clusters.py
ContextSuite context=TestVmAutoScaling>:setup Error 0.00 test_vm_autoscaling.py
test_05_vmschedule_test_e2e Failure 270.12 test_vm_schedule.py
test_02_cancel_host_maintenace_with_migration_jobs Error 0.37 test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure Error 0.41 test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected Failure 50.67 test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected Failure 0.13 test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected Failure 0.13 test_host_maintenance.py

@vishesh92 vishesh92 closed this Aug 25, 2023
@vishesh92 vishesh92 reopened this Aug 25, 2023
@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited

Codecov Report

Merging #7892 (f6d7c6d) into main (f6b2a58) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #7892      +/-   ##
============================================
- Coverage     14.40%   14.40%   -0.01%     
+ Complexity    10116    10115       -1     
============================================
  Files          2748     2748              
  Lines        259424   259426       +2     
  Branches      40385    40385              
============================================
- Hits          37378    37370       -8     
- Misses       217210   217224      +14     
+ Partials       4836     4832       -4
Files Changed Coverage Δ
.../src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java 0.74% <0.00%> (-0.01%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6933

@vishesh92
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@GaOrtiga GaOrtiga mentioned this pull request Aug 29, 2023
Merged
7 tasks
@blueorangutan
Copy link

[SF] Trillian test result (tid-7602)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42986 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7892-t7602-kvm-centos7.zip
Smoke tests completed. 110 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 280.12 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.06 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Failure 3643.63 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Error 3643.75 test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle Error 1.21 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 69.75 test_kubernetes_clusters.py
ContextSuite context=TestVmAutoScaling>:setup Error 0.00 test_vm_autoscaling.py
test_02_cancel_host_maintenace_with_migration_jobs Error 0.36 test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure Error 0.43 test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected Failure 20.41 test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected Failure 20.43 test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected Failure 31.54 test_host_maintenance.py

@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6999

@weizhouapache
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-7650)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42633 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7892-t7650-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 660.23 test_kubernetes_clusters.py

@weizhouapache weizhouapache merged commit 710f34e into apache:main Sep 9, 2023
23 of 26 checks passed
@vishesh92 vishesh92 deleted the fix-list-load-balancer-rule-instances branch September 15, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@vishesh92 vishesh92

Labels
None yet
Projects
None yet
Milestone
4.19.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vishesh92 @blueorangutan @DaanHoogland @weizhouapache @rohityadavcloud