NSX integration #7919

Pearl1594 · 2023-08-28T19:28:08Z

Description

This PR adds support for VMware NSX on CloudStack

Documentation: apache/cloudstack-documentation#378

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Testing on VMware NSX 4.1, CloudStack env vCenter 7.0

\n add nsx controller command

…integration

codecov · 2023-08-28T20:21:22Z

Codecov Report

Attention: Patch coverage is 41.89028% with 1949 lines in your changes are missing coverage. Please review.

Project coverage is 31.31%. Comparing base (3baa45b) to head (2187fdd).
Report is 19 commits behind head on main.

Files	Patch %	Lines
...va/org/apache/cloudstack/service/NsxApiClient.java	6.65%	614 Missing and 3 partials ⚠️
...java/org/apache/cloudstack/service/NsxElement.java	58.57%	117 Missing and 40 partials ⚠️
...va/org/apache/cloudstack/resource/NsxResource.java	49.80%	107 Missing and 22 partials ⚠️
...apache/cloudstack/service/NsxGuestNetworkGuru.java	42.10%	56 Missing and 32 partials ⚠️
ui/src/views/infra/zone/ZoneWizardLaunchZone.vue	0.00%	57 Missing ⚠️
ui/src/views/offering/AddNetworkOffering.vue	0.00%	52 Missing ⚠️
.../org/apache/cloudstack/service/NsxServiceImpl.java	44.70%	43 Missing and 4 partials ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java	38.15%	40 Missing and 7 partials ⚠️
ui/src/views/offering/AddVpcOffering.vue	0.00%	45 Missing ⚠️
...tack/engine/orchestration/NetworkOrchestrator.java	36.66%	28 Missing and 10 partials ⚠️
... and 87 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #7919      +/-   ##
============================================
+ Coverage     29.92%   31.31%   +1.39%     
- Complexity    32240    34740    +2500     
============================================
  Files          5355     5397      +42     
  Lines        375771   386030   +10259     
  Branches      54912    57944    +3032     
============================================
+ Hits         112455   120903    +8448     
- Misses       248321   249075     +754     
- Partials      14995    16052    +1057

Flag	Coverage Δ
simulator-marvin-tests	`24.97% <13.78%> (+1.56%)`	⬆️
uitests	`4.33% <0.44%> (-0.04%)`	⬇️
unit-tests	`16.96% <35.88%> (+0.37%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…integration

nvazquez · 2024-02-26T12:01:15Z

@blueorangutan package

blueorangutan · 2024-02-26T12:02:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-26T13:08:46Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8786

github-actions · 2024-02-26T14:46:22Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

nvazquez · 2024-03-06T14:05:01Z

@blueorangutan package

blueorangutan · 2024-03-06T14:06:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-06T14:19:32Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8865

nvazquez · 2024-03-06T15:20:28Z

@blueorangutan package

blueorangutan · 2024-03-06T15:22:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-06T16:37:00Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8866

nvazquez · 2024-03-06T17:15:02Z

@blueorangutan test matrix

blueorangutan · 2024-03-06T17:16:03Z

@nvazquez a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-03-07T05:50:44Z

[SF] Trillian test result (tid-9409)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43724 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7919-t9409-xenserver-71.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-03-07T07:13:27Z

[SF] Trillian test result (tid-9410)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48686 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7919-t9410-vmware-67u3.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_balanced_drs_algorithm	`Failure`	130.26	test_cluster_drs.py

blueorangutan · 2024-03-07T08:03:43Z

[SF] Trillian test result (tid-9411)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51643 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7919-t9411-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

nvazquez · 2024-03-08T02:33:52Z

Merging based on approvals, test results and extensive testing on NSX 4.1 - vCenter 7.0.3u3

weizhouapache · 2024-03-08T15:56:41Z

Great work !
@Pearl1594 @nvazquez

* NSX integration - skeletal code * Fix module not loading on startup * add upgrade path and daos \n add nsx controller command * add support for adding and listing nsx provider to a zone * add license * add default VPC offering and update upgrade path * add global setting to enable nsx plugin * add delete nsx controller operation * add nsxresource * add NSX resource , api client, create tier1 gw * update db * update response and add license * Add support to create and delete nsx tier-1 gateway * add license * cleanup and add skeletal code for network creation * add create/delete segment and UI integration * add license * address code smells - part 1 * fix test / build failure * NSX integration - skeletal code * Fix module not loading on startup * add upgrade path and daos \n add nsx controller command * add support for adding and listing nsx provider to a zone * add license * add default VPC offering and update upgrade path * add global setting to enable nsx plugin * add delete nsx controller operation * add nsxresource * add NSX resource , api client, create tier1 gw * update db * update response and add license * Add support to create and delete nsx tier-1 gateway * add license * cleanup and add skeletal code for network creation * add create/delete segment and UI integration * add license * address code smells - part 1 * fix test / build failure * add ui changes + update nsx_provider table transport zones + use NSX broadcast domain for add nics to router * ui: fix password field, and backend changes * add route advertisement * update offering * update offering * add sleep before deletion of vpc / tier g/w for ports to be removed * move creation of segments to design phase * change provider to VPC router for Dhcp & dns service in an nsx offering * Add public nic for NSX * reserve first IP (after g/w) of subnet for router nic - NSX * revert reserving 1st IP in vpc segments * [NSX] Create a DHCP relay and add it to a VPC tier segment (#107) * Create DHCP relay command and execute request * In progress integrate with networking * Create DHCP relay config on the network VR allocation * Revert domain router dao changes * Create DHCP relay con VR nic plug to NSX network * Link DHCP relay config to segment after creation * [NSX] Cleanup DHCP Relay config on segment deletion (#108) * Cleanup DHCP Relay config on segment deletion * update segment & relay name generators and call delete dhcprelay after deletion of segment * address comment * [NSX] Fix DHCP relay config deletion was missing zone name (apache#8068) * [NSX] Refactor API wrapper operations (apache#8059) * [NSX] Refactor API wrapper operations * Big refactor * Address review comment * change network cidr to cidr to prevent NPE * add domain and zone names to the various networks - vpc & tier --------- Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * Nsx unit tests (apache#8090) * Add tests * add test for NsxGuestNetworkGuru * add unit tests for NsxResource * add unti tests for NsxElement * cleanup * [NSX] Refactor API wrapper operations * update tests * update tests - add nsxProviderServiceImpl test * add unit test - NsxServiceImpl * add license * Big refactor * Address review comment * change network cidr to cidr to prevent NPE * add domain and zone names to the various networks - vpc & tier * fix tests --------- Co-authored-by: nvazquez <nicovazquez90@gmail.com> * modify NSX resource naming convention (apache#8095) * modify NSX resource naming convention * remove unused imports * add a setup phase between desgin and implementation of a network for intermediary steps * add method to all classes * NSX: Refactor Network & VPC offering (apache#8110) * [NSX] Refactor API wrapper operations * Network offering changes for NSX * fix services and provider combination * address comments: rename param * update nsx_mode parameter --------- Co-authored-by: nvazquez <nicovazquez90@gmail.com> * fix test * [NSX] Allow NSX isolated networks (apache#8132) * Add network offerings for NSX on isolated networks * Fix offerings creation * In progress NSX isolated network * Fixes * Fix NIC allocation to router * NSX: Add Step for Adding Public traffic network for NSX During zone creation (apache#8126) * NSX: Add Step for Adding Public traffic network for NSX * address comments and cleanup * address comment * remove indent * NSX: Create and Delete static NAT & Port forward rules (apache#8131) * NSX: Create and delete NSX Static Nat rules * fix issues with static nat * add static nat * Support to add and delete Port forward rules * add license * fix adding multiple pf rules * cleanup * fix lint check * fix smoke tests * fix smoke tests * Nsx add lb rule (apache#8161) * NSX: Create and delete NSX Static Nat rules * fix issues with static nat * add static nat * Support to add and delete Port forward rules * add license * fix adding multiple pf rules * cleanup * NSX: Add support to create and delete Load balancer rules * fix deletion of lb rules * add header file and update protocol detail * build failure fix * [NSX] Add SNAT support (apache#8100) * In progress add source NAT * Fix after merge * Fix tests * Fix NPE on isolated network deletion * Reserve source NAT IP when its not passed for NSX VPC * Create source NAT rule on VR NIC allocation * Fix update VPC and remove VPC to update and remove SNAT rule * Fix packaging * Address review comment * Fix build * fix build - unused import * Add defensive checks * Add missing design to NSX public guru --------- Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * NSX: Fix VR public NIC allocation (apache#8166) * NSX: fix LB member addition and deletion and add defensive checks (apache#8167) * Fix public NIC NPE on broadcast URI * NSX: Router Public nic to get IP from systemVM Ip range (apache#8172) * NSX: Router Public nic to get IP from systemVM Ip range * Fix VR IP address and setSourceNatIp command * NSX: hide systemVM reserved IP range SourceNAT * fix test --------- Co-authored-by: nvazquez <nicovazquez90@gmail.com> * fix test failure * test failure fix * [NSX] Fix update source NAT IP (apache#8176) * [NSX] Fix update source NAT IP * Fix startup * Fix API result * NSX - add LB route Advertizement (apache#8192) * [NSX] Add ACL types support (apache#8224) * NSX: Create segment group on segment creation * Add unit tests * Remove group for segment before removing segment * Create Distributed Firewall rules * Remove distributed firewall policy on segment deletion * Fix policy rule ID and add more unit tests * Fix DROP action rules and transform tests * Add new ACL rules * Fixes * associate security policies with groups and not to DFW and add deletion of rules * Fix name convention --------- Co-authored-by: Pearl Dsilva <pearl1594@gmail.com> * NSX: Fix creation of VPCs (apache#8320) * Fix ACL rules creation (apache#8323) * [NSX] Fix database views (apache#8325) * NSX: Add CKS Support & Firewall rules for Isolated Networks (apache#8189) * NSX: Add ALL LB IP to the list of route advertisements in tier1 * NSX: Support Source NAT on NSX Isolated networks * NSX: Cks Support * NSX: Create segment group on segment creation * Add unit tests * Remove group for segment before removing segment * Create Distributed Firewall rules * Remove distributed firewall policy on segment deletion * Fix policy rule ID and add more unit tests * Add support for routed NSX Isolated networks \n and non RFC 1918 compliant IPs * Add support for routed NSX Isolated networks \n and non RFC 1918 compliant IPs * Add Firewall rules * build failure - fix unit test * fix npes * Add support to delete firewall rules * update nsx cks offering * add license * update order of ports in PF & FW rules * fix filter for getting transport zones * CKS support changed - MTU updated, etc * add LB for CKS on VPC * address comments * adapt upstream cks logic for vpc * rever mtu hack * update UI changes as per upstream fix * change display test for CKS n/w offerings for isolated and VPC tiers * add extra line for linter * address comment * revert list change --------- Co-authored-by: nvazquez <nicovazquez90@gmail.com> * fix ui build failure * [NSX] Address SonarCloud Bugs (apache#8341) * [NSX] Address SonarCloud Bugs * Fix NSX API connection issues * NSX: Add unit tests to increase coverage (apache#8355) * NSX: Add unit tests * cleanup unused imports * add more unit tests * add tests for publicnsxnetworkguru * add license * fix build failures * address sonar comment * fix security hotspots * NSX: Add more unit tests (apache#8381) * NSX : Unit tests * remove unused imports * remove unused import causing build failure * fix build failures due to unused imports * fix build failure * fix test assertion * remove unused imports * remove unused import * Nsx UI zone bug (apache#8398) * NSX: Attempt to fix NSX Zone creation bug for public networks * fix zone wizard public traffic issue * add proper filtering of offerings based on VPC nsx mode * clean up console logs * NSX: Fix code smells and reported bugs (apache#8409) * NSX: Fix code smells and reported bugs * fox override issue * remove unused imports * fix test * refactor code to reduce complexity * add lisence * cleanup * fix build failure * fix build failure * address comments * test - add config to ignore certain files from test coverage * test exclusion of classes from test cov * rever pom changes * [NSX] Add more unit tests (apache#8431) * [NSX] Add more unit tests * More tests * Fix build errors * NSX: Prevent creation of L2 and Shared networks for NSX (apache#8463) * NSX: Prevent creation of L2 and Shared networks for NSX * add checks to backend to prevent creation of l2 and shared networks in nsx zones and filter only nsx offerings when creating isolated networks * cleanup * NSX: Fix code smells (apache#8436) * NSX: Fix code smells * Add changes to service creation logic * CKS: Add action to during firewall rule creation (apache#8498) * NSX,UI: Deduplicate network list when creating kubernetes clusters (apache#8513) * NSX: Make LB service selectable in network offering (apache#8512) * NSX: Make LB service selectable in network offering * fix label * address comments * address comments * NSX: Add appropriate error message when icmp type is set to -1 for NSX (apache#8504) * NSX: Add appropriate error message when icmp type is set to -1 for NSX * address comments * update text * fix test * fix test - build failure * fix test - build failure * NSX: Cleanup NSX resources during k8s cluster cleanup (apache#8528) * fix test failure * NSX: Improve segment deletion process (apache#8538) * NSX: Add passive monitor for NSX LB to test whether a server is available (apache#8533) * NSX: Add passive monitor for NSX LB to test whether a server is available * Add active monitors too * fix build failure * NSX: Add check for ICMP code / type for NSX zones (apache#8542) * NSX: Fix Routed Mode for Isolated and VPC networks (apache#8534) * NSX: Fix Routed Mode for Isolated and VPC networks * NSX: Fix Routed mode - add checks for ports added for FW rules * clean up code * fix build failure * NSX: Add retry logic with sleep to delete segments (apache#8554) * NSX: Add retry logic with sleep to delete segments * add logs * NSX: Fix custom ACL check (#2) * NSX: Fix custom ACL check * NSX: Fix custom ACL check * Nsx vpc routed mode (#5) * NSX: Fix VPC routed mode * NSX: VPC route mode * remove unnecessary changes * Nsx: Support internal LB (#4) * NSX: Support internal LB service in NSX * add lb removal logic * Fix UI issue hiding internal LB tab * Refactor method name --------- Co-authored-by: nvazquez <nicovazquez90@gmail.com> * NSX: Improve NSX resource cleanup process (#3) * Fix unit test * NSX: Add SourceNAT service to the default Routed offering for VPC (#13) * Fix VPC restart with cleanup (#12) * NSX: Fix ACL rule removal on replacement and fix rule order (#11) * NSX: fix smoke test failure for ACLs (#9) * Fix unit tests * Fix NSX plugin pom XML * NSX: Add support to re-order ACL rules (NSX FW rules) (#14) * [WIP] NSX: Add support to re-order ACL rules (NSX FW rules) * fix reordering of acl rules on all networks that it is associated to * clean up and attempt test fix * Fix tests * Remove unused import * tweak reorder logic --------- Co-authored-by: nvazquez <nicovazquez90@gmail.com> * Fix zone creation issue for internal load balancer * Fix * Fix unit test * fix logger * fix logger * fix logger * NSX: Fix VPC form to ignore source NAT IP when creating VPCs and fix label * Move SQL changes to the newest schema file * NSX: Last Fixes * Fix build --------- Co-authored-by: nvazquez <nicovazquez90@gmail.com>

Pearl1594 and others added 15 commits August 15, 2023 07:23

NSX integration - skeletal code

446dd83

Fix module not loading on startup

e886165

add upgrade path and daos

2c0f51e

\n add nsx controller command

add support for adding and listing nsx provider to a zone

2b0ddc6

add license

50879ea

add default VPC offering and update upgrade path

3179a3e

add global setting to enable nsx plugin

357f217

add delete nsx controller operation

913d0bc

add nsxresource

9c22bda

add NSX resource , api client, create tier1 gw

e0244e2

Merge branch 'main' of https://github.com/apache/cloudstack into nsx-…

d8998d0

…integration

update db

bb9b644

update response and add license

937b34b

Merge branch 'main' of https://github.com/apache/cloudstack into nsx-…

b37a9f7

…integration

Add support to create and delete nsx tier-1 gateway

bedfe44

boring-cyborg bot added component:api component:build component:networking component:orchestration labels Aug 28, 2023

Pearl1594 changed the title ~~Nsx integration~~ NSX integration Aug 28, 2023

add license

996821d

cleanup and add skeletal code for network creation

b0933bb

Pearl1594 force-pushed the nsx-integration branch from 3f48ac4 to b0933bb Compare August 29, 2023 19:01

Pearl1594 added 3 commits September 6, 2023 10:32

Merge branch 'main' of https://github.com/apache/cloudstack into nsx-…

2cccd53

…integration

add create/delete segment and UI integration

37d6344

add license

e443f13

Pearl1594 force-pushed the nsx-integration branch from 6f382e7 to 9685f87 Compare September 7, 2023 14:03

address code smells - part 1

d378130

Pearl1594 force-pushed the nsx-integration branch from 9685f87 to d378130 Compare September 7, 2023 14:56

github-actions bot removed the status:has-conflicts label Feb 26, 2024

github-actions bot added the status:has-conflicts label Feb 26, 2024

Merge branch 'main' into nsx-integration

869a51a

github-actions bot removed the status:has-conflicts label Feb 26, 2024

NSX: Last Fixes

012dd03

Fix build

2187fdd

nvazquez merged commit 6dc3d06 into main Mar 8, 2024
44 of 48 checks passed

Pearl1594 mentioned this pull request Apr 12, 2024

NSX Integration fixes #8906

Draft

13 tasks

This was referenced Apr 24, 2024

vpc: create vpc tiers with dns server of vpc instead of zone #8621

Merged

CKS cluster with HA enabled has port forwarding rules to one control VM #8295

Closed

This was referenced Jun 5, 2024

NSX: Cleanup PF rule when VM is expunged and fix UDP - LB rules #8699

Closed

NSX: Support ACL Rules re-ordering in NSX #8618

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NSX integration #7919

NSX integration #7919

Pearl1594 commented Aug 28, 2023 •

edited by nvazquez

codecov bot commented Aug 28, 2023 •

edited

nvazquez commented Feb 26, 2024

blueorangutan commented Feb 26, 2024

blueorangutan commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

nvazquez commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

nvazquez commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

nvazquez commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

blueorangutan commented Mar 7, 2024

blueorangutan commented Mar 7, 2024

blueorangutan commented Mar 7, 2024

nvazquez commented Mar 8, 2024

weizhouapache commented Mar 8, 2024

NSX integration #7919

NSX integration #7919

Conversation

Pearl1594 commented Aug 28, 2023 • edited by nvazquez

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

codecov bot commented Aug 28, 2023 • edited

Codecov Report

nvazquez commented Feb 26, 2024

blueorangutan commented Feb 26, 2024

blueorangutan commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

nvazquez commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

nvazquez commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

nvazquez commented Mar 6, 2024

blueorangutan commented Mar 6, 2024

blueorangutan commented Mar 7, 2024

blueorangutan commented Mar 7, 2024

blueorangutan commented Mar 7, 2024

nvazquez commented Mar 8, 2024

weizhouapache commented Mar 8, 2024

Pearl1594 commented Aug 28, 2023 •

edited by nvazquez

codecov bot commented Aug 28, 2023 •

edited