LibvirtServerDiscoverer should only process added hosts relevant to hypervisor type

[mlsorensen]

Description

This PR keeps LibvirtServerDiscoverer from attempting to push direct download certs to other hosts when addHost API is used to add direct agent hosts and direct download certs are installed.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested locally by adding simulator hosts via API after adding direct download certs to zone.

[codecov]

Codecov Report

Merging #7979 (6f92859) into main (0375714) will increase coverage by 0.38%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #7979      +/-   ##
============================================
+ Coverage     28.79%   29.17%   +0.38%     
- Complexity    29993    30391     +398     
============================================
  Files          5100     5100              
  Lines        358320   358321       +1     
  Branches      52308    52308              
============================================
+ Hits         103165   104528    +1363     
+ Misses       240925   239419    -1506     
- Partials      14230    14374     +144     

Flag	Coverage Δ
simulator-marvin-tests	25.18% <50.00%> (+0.46%)	⬆️
uitests	4.87% <ø> (ø)
unit-tests	14.42% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java	8.10% <0.00%> (-0.46%)	⬇️
.../hypervisor/discoverer/CustomServerDiscoverer.java	75.00% <100.00%> (+8.33%)	⬆️

... and 132 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rohityadavcloud]

LGTM

[rohityadavcloud]

@blueorangutan package

[GabrielBrascher]

LGTM

[DaanHoogland]

clgtm

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7105

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7722)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52373 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7979-t7722-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	3616.32	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	3618.98	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	0.03	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.03	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.03	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Failure	46.64	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	Error	1.23	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	55.45	test_kubernetes_clusters.py
test_05_vmschedule_test_e2e	Failure	260.81	test_vm_schedule.py

[weizhouapache]

code lgtm

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7724)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52722 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7979-t7724-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	3617.82	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	3600.54	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.03	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Failure	48.75	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	Error	0.20	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	70.76	test_kubernetes_clusters.py