Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style for LibvirtComputingResource variable names and its dependencies #7991

Merged

Conversation

mlsorensen
Copy link
Contributor

Description

This PR refactors variable names for LibvirtComputingResource according to new style standards. It also refactors the variables in classes that were dependent on these variable names, to try to improve consistency.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

It compiles without missing any symbols. Let's see how smoke tests do :-)

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #7991 (fde4dac) into main (84277e7) will decrease coverage by 0.90%.
The diff coverage is 8.92%.

@@             Coverage Diff              @@
##               main    #7991      +/-   ##
============================================
- Coverage     29.14%   28.25%   -0.90%     
+ Complexity    30375    29312    -1063     
============================================
  Files          5100     5100              
  Lines        358320   358320              
  Branches      52308    52308              
============================================
- Hits         104446   101246    -3200     
- Misses       239520   243052    +3532     
+ Partials      14354    14022     -332     
Flag Coverage Δ
simulator-marvin-tests 24.02% <8.92%> (-1.12%) ⬇️
uitests 4.87% <ø> (ø)
unit-tests 14.43% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...nt/resource/consoleproxy/ConsoleProxyResource.java 0.00% <0.00%> (ø)
...ervisor/kvm/resource/LibvirtComputingResource.java 18.69% <ø> (ø)
...in/java/com/cloud/resource/ServerResourceBase.java 4.37% <9.37%> (ø)
...r/hyperv/resource/HypervDirectConnectResource.java 1.07% <14.89%> (ø)

... and 246 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@GutoVeronezi GutoVeronezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueorangutan package

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some more renaming can be done but doesn't have to be in this PR (priv => private, Nw => Network, Distro => Distribution, etc...)

@rohityadavcloud rohityadavcloud added this to the 4.19.0.0 milestone Sep 26, 2023
@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7106

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link

[SF] Trillian test result (tid-7721)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52642 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7991-t7721-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_invalid_upgrade_kubernetes_cluster Failure 3613.20 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 3616.98 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Failure 54.81 test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle Error 1.21 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 68.66 test_kubernetes_clusters.py

@rohityadavcloud rohityadavcloud merged commit 28c4be1 into apache:main Sep 27, 2023
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants