New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style for LibvirtComputingResource variable names and its dependencies #7991
Fix style for LibvirtComputingResource variable names and its dependencies #7991
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7991 +/- ##
============================================
- Coverage 29.14% 28.25% -0.90%
+ Complexity 30375 29312 -1063
============================================
Files 5100 5100
Lines 358320 358320
Branches 52308 52308
============================================
- Hits 104446 101246 -3200
- Misses 239520 243052 +3532
+ Partials 14354 14022 -332
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 246 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blueorangutan package
agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, some more renaming can be done but doesn't have to be in this PR (priv => private, Nw => Network, Distro => Distribution, etc...)
@blueorangutan package |
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7106 |
@blueorangutan test |
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
[SF] Trillian test result (tid-7721)
|
Description
This PR refactors variable names for LibvirtComputingResource according to new style standards. It also refactors the variables in classes that were dependent on these variable names, to try to improve consistency.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
It compiles without missing any symbols. Let's see how smoke tests do :-)