New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cleanup directory if empty after removal of snapshot #8002
fix: cleanup directory if empty after removal of snapshot #8002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a quick test with hidden files and code looks good
Codecov Report
@@ Coverage Diff @@
## 4.18 #8002 +/- ##
============================================
+ Coverage 13.02% 13.06% +0.04%
- Complexity 9032 9106 +74
============================================
Files 2720 2720
Lines 257080 257500 +420
Branches 40088 40149 +61
============================================
+ Hits 33476 33649 +173
- Misses 219400 219621 +221
- Partials 4204 4230 +26
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@blueorangutan package |
@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
...server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
Outdated
Show resolved
Hide resolved
...server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
...server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
Outdated
Show resolved
Hide resolved
…udstack/storage/resource/NfsSecondaryStorageResource.java Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7109 |
@blueorangutan package |
@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7110 |
@blueorangutan test |
@vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
...server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
Show resolved
Hide resolved
[SF] Trillian test result (tid-7723)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
* 4.18: fix: cleanup directory if empty after removal of snapshot (#8002)
Description
This PR removes the directory of snapshot if it's empty after removal of snapshot.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?