Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need people to do better testing #8035

Merged
merged 1 commit into from Oct 4, 2023
Merged

Conversation

DaanHoogland
Copy link
Contributor

Description

This PR adds an extra question to the PR template.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #8035 (19146b8) into main (2e9b3d8) will increase coverage by 0.66%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8035      +/-   ##
============================================
+ Coverage     28.57%   29.24%   +0.66%     
- Complexity    29784    30502     +718     
============================================
  Files          5100     5100              
  Lines        358565   358565              
  Branches      52316    52316              
============================================
+ Hits         102464   104848    +2384     
+ Misses       241968   239349    -2619     
- Partials      14133    14368     +235     
Flag Coverage Δ
simulator-marvin-tests 25.20% <ø> (+0.89%) ⬆️
uitests 4.86% <ø> (ø)
unit-tests 14.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 197 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rohityadavcloud rohityadavcloud added this to the 4.19.0.0 milestone Oct 4, 2023
@rohityadavcloud
Copy link
Member

Doc-only, template fix - LGTM let's merge.

@rohityadavcloud rohityadavcloud merged commit cc6f21b into main Oct 4, 2023
44 of 47 checks passed
@rohityadavcloud rohityadavcloud deleted the moreTestingRequired branch October 4, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants