systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service

[weizhouapache]

Description

the service user@0.service fails in system vms and virtual routers

This PR removes a change to fix memory leak of SSH connections in the systemvm templates with old linux kernel.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7250

[codecov]

Codecov Report

Merging #8048 (29cddc7) into 4.18 (3d8cc63) will decrease coverage by 0.01%.
Report is 3 commits behind head on 4.18.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #8048      +/-   ##
============================================
- Coverage     13.07%   13.06%   -0.01%     
+ Complexity     9107     9106       -1     
============================================
  Files          2720     2720              
  Lines        257513   257513              
  Branches      40151    40151              
============================================
- Hits          33658    33649       -9     
- Misses       219624   219634      +10     
+ Partials       4231     4230       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

looks good, the original bug for which this was introduced is fixed. I see no reference to any problems, so it should be good. Not sure if we can test anything other than the SVMs running fine.

[shwstppr]

@weizhouapache this will require new systemvm template?

[weizhouapache]

@weizhouapache this will require new systemvm template?

@shwstppr
I think so
the changes with init.sh and cloud-early-config require new systemvm template

[rohityadavcloud]

LGTM - didn't test it but changes make sense, esp that the upstream systemd is fixed

[rohityadavcloud]

@weizhouapache @DaanHoogland @harikrishna-patnala I'm assuming this doesn't require a systemvmtemplate build (since changes are not in the cloud-early-config ?)

[shwstppr]

@rohityadavcloud This may require new systemvm template build. #8048 (comment)

[rohityadavcloud]

Thanks @shwstppr @weizhouapache - that seems to be correct, but the other question is - is this fixing any issue? Is the failure of the service causing issues with systemvms and vrouters?

[weizhouapache]

@rohityadavcloud
this fixes the service user@0.service in VRs and system vms.
but It seems other services in the vms are not impacted by the failure with user@0.service. this is a minor/trivial issue

[rohityadavcloud]

Thanks for checking @weizhouapache cc @shwstppr - if necessary let's build systemvmtemplate for 4.19.0 ?