Fix UUID for child datastores in all cases #8057

harikrishna-patnala · 2023-10-09T11:24:53Z

Description

This PR fixes the issue #7999

While putting the storage pool datastore cluster in maintenance mode, then there are chances that the cloud.uuid gets updated with UUID without hyphens ('-') which causes issue with sync storage pool.

In my case this is happening if there any hosts in the clusters which does not have access to the storage pool.

In this PR we are making sure that the UUID does not change to uuid without hyphens

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Bug Severity

Screenshots (if appropriate):

Before and after putting the storage pool in maintenance mode, cloud.uuid has not changed

Before the fix, this UUID has changed to UUID without hyphens

How Has This Been Tested?

Prepare a datastore cluster with 2 child datastores
Add datastore cluster as primary storage in CloudStack
Put the datastore cluster in maintenance mode or restart management server (as part of the fix, make sure the cloud.uuid in child storage pool does not. UUID has to be with hyphens)
Add or remove new child datastore in vCenter
Try sync storage pool operation on the datastore cluster => succeeded.

How did you try to break this feature and the system with this change?

harikrishna-patnala · 2023-10-09T11:28:29Z

@blueorangutan package

blueorangutan · 2023-10-09T11:30:04Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-09T12:25:23Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7277

codecov · 2023-10-09T12:28:34Z

Codecov Report

Merging #8057 (d58c14d) into 4.18 (29c7b31) will increase coverage by 0.04%.
Report is 71 commits behind head on 4.18.
The diff coverage is 18.27%.

@@             Coverage Diff              @@
##               4.18    #8057      +/-   ##
============================================
+ Coverage     13.02%   13.06%   +0.04%     
- Complexity     9032     9108      +76     
============================================
  Files          2720     2720              
  Lines        257080   257537     +457     
  Branches      40088    40156      +68     
============================================
+ Hits          33476    33658     +182     
- Misses       219400   219649     +249     
- Partials       4204     4230      +26

Files	Coverage Δ
...hestration/service/VolumeOrchestrationService.java	`100.00% <ø> (ø)`
.../main/java/com/cloud/network/IpAddressManager.java	`100.00% <100.00%> (ø)`
...ava/com/cloud/network/as/AutoScaleVmProfileVO.java	`80.20% <100.00%> (+11.66%)`	⬆️
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java	`40.89% <100.00%> (+0.64%)`	⬆️
...va/com/cloud/upgrade/DatabaseVersionHierarchy.java	`85.10% <100.00%> (+1.01%)`	⬆️
.../api/command/admin/ratelimit/ResetApiLimitCmd.java	`0.00% <ø> (ø)`
...oud/hypervisor/kvm/resource/LibvirtConnection.java	`0.00% <ø> (ø)`
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java	`10.44% <100.00%> (ø)`
...ava/com/cloud/api/commands/StopNetScalerVMCmd.java	`0.00% <ø> (ø)`
...tungsten/api/command/ListTungstenFabricTagCmd.java	`0.00% <ø> (ø)`
... and 58 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DaanHoogland

clgtm

rohityadavcloud

LGTM - didn't test it though

rohityadavcloud · 2023-10-10T10:20:48Z

@blueorangutan alma8 vmware-70u3

DaanHoogland · 2023-10-10T11:18:16Z

@blueorangutan alma8 vmware-70u3

yeah, i make that mistake all the time

DaanHoogland · 2023-10-10T11:18:32Z

@blueorangutan test alma8 vmware-70u3

blueorangutan · 2023-10-10T11:20:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2023-10-11T03:35:06Z

[SF] Trillian test result (tid-7905)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8
Total time taken: 56705 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8057-t7905-vmware-70u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	`Error`	3603.23	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	1.28	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	2.33	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	2.35	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.29	test_vm_deployment_planner.py

DaanHoogland · 2023-10-11T08:38:30Z

@blueorangutan test rocky8 vmware-67u3

blueorangutan · 2023-10-11T08:40:04Z

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2023-10-13T01:51:35Z

[SF] Trillian test result (tid-7914)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 146853 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8057-t7914-vmware-67u3.zip
Smoke tests completed. 104 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.04	test_ssvm.py
test_06_stop_cpvm	`Failure`	0.04	test_ssvm.py
test_07_reboot_ssvm	`Failure`	100.18	test_ssvm.py
test_11_destroy_ssvm	`Failure`	920.72	test_ssvm.py
test_08_arping_in_ssvm	`Failure`	5.23	test_diagnostics.py
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3608.63	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	3611.06	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.07	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.06	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.06	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	1081.21	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	1175.93	test_kubernetes_clusters.py
test_01_scale_up_verify	`Failure`	576.63	test_vm_autoscaling.py

harikrishna-patnala · 2023-10-13T05:02:30Z

@blueorangutan test rocky8 vmware-67u3

blueorangutan · 2023-10-13T05:04:04Z

@harikrishna-patnala a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2023-10-13T22:25:44Z

[SF] Trillian test result (tid-7951)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 61003 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8057-t7951-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	`Error`	12.59	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3601.71	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.36	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	2.37	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.33	test_vm_deployment_planner.py

rohityadavcloud · 2023-10-16T06:08:50Z

@harikrishna-patnala can you review the failures, are they due to this PR - or can we merge this PR?

harikrishna-patnala · 2023-10-17T03:36:25Z

This can be merged @rohityadavcloud. Those seems to intermittent failures, PR changes are purely related to datastore cluster

* 4.18: Fix UUID for child datastores in all cases (#8057)

(cherry picked from commit 76ab621) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Fix UUID for child datastores in all cases

d58c14d

boring-cyborg bot added the component:vmware label Oct 9, 2023

harikrishna-patnala added this to the 4.18.2.0 milestone Oct 9, 2023

DaanHoogland approved these changes Oct 9, 2023

View reviewed changes

rohityadavcloud approved these changes Oct 10, 2023

View reviewed changes

DaanHoogland closed this Oct 11, 2023

DaanHoogland reopened this Oct 11, 2023

rohityadavcloud merged commit 76ab621 into apache:4.18 Oct 18, 2023
47 of 50 checks passed

rohityadavcloud deleted the FixDatastoreClusterUUID branch October 18, 2023 07:30

rohityadavcloud mentioned this pull request Oct 18, 2023

Sync storage pool failed on VMware datastore cluster primary storage #7999

Closed

DaanHoogland added a commit that referenced this pull request Oct 18, 2023

Merge release branch 4.18 to main

8eaf264

* 4.18: Fix UUID for child datastores in all cases (#8057)

shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Dec 27, 2023

Fix UUID for child datastores in all cases (apache#8057)

4c7a81b

(cherry picked from commit 76ab621) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix UUID for child datastores in all cases #8057

Fix UUID for child datastores in all cases #8057

harikrishna-patnala commented Oct 9, 2023 •

edited

harikrishna-patnala commented Oct 9, 2023

blueorangutan commented Oct 9, 2023

blueorangutan commented Oct 9, 2023

codecov bot commented Oct 9, 2023 •

edited

DaanHoogland left a comment

rohityadavcloud left a comment

rohityadavcloud commented Oct 10, 2023

DaanHoogland commented Oct 10, 2023

DaanHoogland commented Oct 10, 2023

blueorangutan commented Oct 10, 2023

blueorangutan commented Oct 11, 2023

DaanHoogland commented Oct 11, 2023

blueorangutan commented Oct 11, 2023

blueorangutan commented Oct 13, 2023

harikrishna-patnala commented Oct 13, 2023

blueorangutan commented Oct 13, 2023

blueorangutan commented Oct 13, 2023

rohityadavcloud commented Oct 16, 2023

harikrishna-patnala commented Oct 17, 2023

Fix UUID for child datastores in all cases #8057

Fix UUID for child datastores in all cases #8057

Conversation

harikrishna-patnala commented Oct 9, 2023 • edited

Description

Types of changes

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

harikrishna-patnala commented Oct 9, 2023

blueorangutan commented Oct 9, 2023

blueorangutan commented Oct 9, 2023

codecov bot commented Oct 9, 2023 • edited

Codecov Report

DaanHoogland left a comment

Choose a reason for hiding this comment

rohityadavcloud left a comment

Choose a reason for hiding this comment

rohityadavcloud commented Oct 10, 2023

DaanHoogland commented Oct 10, 2023

DaanHoogland commented Oct 10, 2023

blueorangutan commented Oct 10, 2023

blueorangutan commented Oct 11, 2023

DaanHoogland commented Oct 11, 2023

blueorangutan commented Oct 11, 2023

blueorangutan commented Oct 13, 2023

harikrishna-patnala commented Oct 13, 2023

blueorangutan commented Oct 13, 2023

blueorangutan commented Oct 13, 2023

rohityadavcloud commented Oct 16, 2023

harikrishna-patnala commented Oct 17, 2023

harikrishna-patnala commented Oct 9, 2023 •

edited

codecov bot commented Oct 9, 2023 •

edited