Add logs to listLoadBalancerRuleInstances API

[winterhazel]

Description

The listLoadBalancerRuleInstances API does not have any logs providing useful information. This PR adds logs to this API in order to facilitate troubleshooting.

This PR was based on the changes in #6357.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

How Has This Been Tested?

• I created a Load Balancer rule and called the listLoadBalancerRuleInstances API through CloudMonkey. Then, I verified that the command returned the expected response and that the correct messages were logged;
• I created a VM, added it to the rule and called the listLoadBalancerRuleInstances API through CloudMonkey. Then, I verified that the command returned the expected response and that the correct messages were logged.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (55bef2b) 22.30% compared to head (b64c40b) 29.12%.
Report is 116 commits behind head on main.

Files	Patch %	Lines
...loud/network/lb/LoadBalancingRulesManagerImpl.java	65.38%	6 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8094      +/-   ##
============================================
+ Coverage     22.30%   29.12%   +6.81%     
- Complexity    21769    31205    +9436     
============================================
  Files          4967     5234     +267     
  Lines        336852   368370   +31518     
  Branches      48389    53737    +5348     
============================================
+ Hits          75119   107270   +32151     
+ Misses       250821   246401    -4420     
- Partials      10912    14699    +3787     

Flag	Coverage Δ
simulator-marvin-tests	25.04% <81.25%> (+1.29%)	⬆️
uitests	4.44% <ø> (-0.41%)	⬇️
unit-tests	14.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[winterhazel]

Hey guys, could someone review this?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7869

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-8434)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53000 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8094-t8434-kvm-centos7.zip
Smoke tests completed. 117 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	3619.41	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	3624.93	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	0.05	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	Failure	0.05	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Failure	46.80	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	Error	1.24	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	57.59	test_kubernetes_clusters.py

[DaanHoogland]

All log messages are (unguarded) debug messages. Is this intentional? i.e. are they not interesting to operators?

Other than that CLGTM

[winterhazel]

@DaanHoogland yes, this is intentional since these messages are interesting for people debugging the code, and the process is easily reproducible; however, I changed the level of a message better suited for info.

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7894

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-8457)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56730 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8094-t8457-kvm-centos7.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	3619.29	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	2582.57	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	294.00	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	72.78	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Failure	50.93	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	Error	0.25	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	77.19	test_kubernetes_clusters.py