Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,refactor: fix test_project_resources cleanup #8097

Merged
merged 1 commit into from Oct 16, 2023
Merged

test,refactor: fix test_project_resources cleanup #8097

merged 1 commit into from Oct 16, 2023

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Oct 15, 2023 •
edited

Description

Use super class method for cleanup of the resources.
Fixes simulator CI failures observed on different PRs lately.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023 •
edited

Codecov Report

Merging #8097 (471177c) into 4.18 (ba24a18) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #8097   +/-   ##
=========================================
  Coverage     13.07%   13.07%           
  Complexity     9110     9110           
=========================================
  Files          2720     2720           
  Lines        257526   257526           
  Branches      40150    40150           
=========================================
  Hits          33661    33661           
  Misses       219636   219636           
  Partials       4229     4229

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shwstppr shwstppr marked this pull request as ready for review October 16, 2023 07:45
rohityadavcloud
rohityadavcloud approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - need to check smoketests

@rohityadavcloud rohityadavcloud added this to the 4.19.0.0 milestone Oct 16, 2023
@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@shwstppr
Copy link
Contributor Author

As the test is under component, smoke tests won't show any difference. GH action passes now. @rohityadavcloud

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 7373

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7381

@shwstppr
Copy link
Contributor Author

shwstppr commented Oct 16, 2023 •
edited

Merging this as the change is the component test and GH action for simulator CI is passing now.

Change needs to go in 4.18 also as it is having the same failure. Rebasing

@shwstppr shwstppr changed the base branch from main to 4.18 October 16, 2023 12:57
@shwstppr
test,refactor: fix test_project_resources cleanup
471177c 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr force-pushed the fix-test-project-resources-sim-ci branch from 99fdbd1 to 471177c Compare October 16, 2023 13:03
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@DaanHoogland DaanHoogland modified the milestones: 4.19.0.0, 4.18.2.0 Oct 16, 2023
@blueorangutan
Copy link

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7387

@DaanHoogland
Copy link
Contributor

test passed in gha, merging

@DaanHoogland DaanHoogland merged commit 065abe2 into apache:4.18 Oct 16, 2023
27 checks passed
@DaanHoogland DaanHoogland deleted the fix-test-project-resources-sim-ci branch October 16, 2023 14:25
DaanHoogland added a commit that referenced this pull request Oct 16, 2023
@DaanHoogland
Merge release branch 4.18 to main
c9d2303 
* 4.18:
  test,refactor: fix test_project_resources cleanup (#8097)
  kvm: fix direct download template size (#8093)
shwstppr added a commit to shapeblue/cloudstack that referenced this pull request Dec 27, 2023
@shwstppr @rohityadavcloud
test,refactor: fix test_project_resources cleanup (apache#8097)
03fa579 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
(cherry picked from commit 065abe2)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees
No one assigned
Labels
component:agent component:api component:build component:integration component:integration-test Python Warning... Python code Ahead!
Projects
None yet
Milestone
4.18.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shwstppr @rohityadavcloud @blueorangutan @DaanHoogland