Fix VM snapshot size during storage capacity check

[harikrishna-patnala]

Description

This PR fixes the issue #8054

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

1. created a VM with one root (2GB) and data (5GB) disks

2. create VM snapshot and the primary storage usage looks like below
   

3. After this is fixed, usage considered 5GB data disk size as well
   

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Merging #8101 (050ca00) into 4.18 (fb3a2ec) will decrease coverage by 0.01%.
Report is 2 commits behind head on 4.18.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #8101      +/-   ##
============================================
- Coverage     13.07%   13.06%   -0.01%     
- Complexity     9108     9109       +1     
============================================
  Files          2720     2720              
  Lines        257528   257524       -4     
  Branches      40153    40150       -3     
============================================
- Hits          33659    33654       -5     
- Misses       219639   219643       +4     
+ Partials       4230     4227       -3     

Files	Coverage Δ
...main/java/com/cloud/storage/dao/VolumeDaoImpl.java	23.11% <ø> (-0.13%)	⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rohityadavcloud]

LGTM - didn't test it though

[DaanHoogland]

@blueorangutan test

[DaanHoogland]

less == more, needs testing though

[shwstppr]

Code LGTM

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7394

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

tested manually according to description, works as expected

[blueorangutan]

[SF] Trillian test result (tid-7995)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46173 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8101-t7995-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	Failure	580.25	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	48.23	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	3609.51	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	283.85	test_kubernetes_clusters.py
test_03_deploy_vm_wrong_checksum	Error	39.60	test_templates.py
test_09_list_templates_download_details	Failure	0.04	test_templates.py