Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup: register vmscheduler configkey #8116

Merged
merged 1 commit into from Oct 25, 2023

Conversation

vishesh92
Copy link
Member

Description

This PR registers VMScheduledJobExpireInterval.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #8116 (18088b1) into main (d3d3027) will increase coverage by 0.84%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #8116      +/-   ##
============================================
+ Coverage     28.59%   29.43%   +0.84%     
- Complexity    29726    31216    +1490     
============================================
  Files          5101     5111      +10     
  Lines        358806   370618   +11812     
  Branches      52362    56766    +4404     
============================================
+ Hits         102590   109092    +6502     
- Misses       242029   246466    +4437     
- Partials      14187    15060     +873     
Flag Coverage Δ
simulator-marvin-tests 25.57% <100.00%> (+1.20%) ⬆️
uitests 4.79% <ø> (-0.06%) ⬇️
unit-tests 14.51% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...apache/cloudstack/vm/schedule/VMSchedulerImpl.java 83.00% <100.00%> (+13.30%) ⬆️

... and 270 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@shwstppr shwstppr added this to the 4.19.0.0 milestone Oct 18, 2023
@shwstppr
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6206

@shwstppr
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-8001)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41825 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8116-t8001-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_vm_wrong_checksum Error 40.58 test_templates.py
test_09_list_templates_download_details Failure 0.04 test_templates.py
test_05_vmschedule_test_e2e Failure 361.53 test_vm_schedule.py

@weizhouapache
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-8026)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44680 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8116-t8026-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_upgrade_kubernetes_cluster Failure 577.79 test_kubernetes_clusters.py
test_03_deploy_vm_wrong_checksum Error 39.56 test_templates.py
test_09_list_templates_download_details Failure 0.05 test_templates.py

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, not sure why this would have functioned without it ever.

@DaanHoogland
Copy link
Contributor

trying to rebuild/test again to see about the inconsistent results

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7450

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-8038)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45160 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8116-t8038-kvm-centos7.zip
Smoke tests completed. 109 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 336.68 test_safe_shutdown.py
test_08_upgrade_kubernetes_ha_cluster Failure 619.14 test_kubernetes_clusters.py
test_01_vpc_site2site_vpn Failure 280.62 test_vpc_vpn.py
test_hostha_enable_ha_when_host_in_maintenance Error 304.81 test_hostha_kvm.py

@DaanHoogland
Copy link
Contributor

@blueorangutan test alma8 kvm-alma8

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-8064)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 49732 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8116-t8064-kvm-alma8.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 932.54 test_kubernetes_clusters.py

@rohityadavcloud
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-8079)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43582 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8116-t8079-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_upgrade_kubernetes_cluster Failure 561.54 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 713.12 test_kubernetes_clusters.py

@shwstppr shwstppr merged commit 27ae7d8 into apache:main Oct 25, 2023
36 of 49 checks passed
@DaanHoogland DaanHoogland deleted the fixup-vmscheduler-config branch October 26, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants