Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix snapshot copy actions for non-rootadmins #8164

Merged
merged 1 commit into from Nov 1, 2023

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Oct 31, 2023

Description

Fixes Snapshot copy, zone delete option not showing in UI for non-rootadmin roles.
We already use param in API call to filter backed up snapshot copies.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2023-10-31 18-17-27

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes Snapshot copy, zone delete option not showing in UI for non-rootadmin roles

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #8164 (3f9c97e) into main (8fe13f9) will decrease coverage by 6.93%.
Report is 12 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8164      +/-   ##
============================================
- Coverage     27.89%   20.96%   -6.93%     
+ Complexity    28873    20559    -8314     
============================================
  Files          5111     5031      -80     
  Lines        360674   342193   -18481     
  Branches      52702    49340    -3362     
============================================
- Hits         100605    71737   -28868     
- Misses       246179   259981   +13802     
+ Partials      13890    10475    -3415     
Flag Coverage Δ
simulator-marvin-tests 22.40% <ø> (-1.07%) ⬇️
uitests 4.53% <ø> (-0.27%) ⬇️
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ui/src/views/storage/SnapshotZones.vue 0.00% <ø> (ø)

... and 1774 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7578

@shwstppr
Copy link
Contributor Author

shwstppr commented Nov 1, 2023

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8164 (QA-JID-215)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button shows for domain admin; lgtm

@shwstppr shwstppr merged commit 2dac6cb into apache:main Nov 1, 2023
19 of 48 checks passed
@shwstppr shwstppr deleted the fix-ui-snpacopy-nonadmin branch November 1, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants