New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix snapshot copy actions for non-rootadmins #8164
Conversation
Fixes Snapshot copy, zone delete option not showing in UI for non-rootadmin roles Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@blueorangutan package |
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report
@@ Coverage Diff @@
## main #8164 +/- ##
============================================
- Coverage 27.89% 20.96% -6.93%
+ Complexity 28873 20559 -8314
============================================
Files 5111 5031 -80
Lines 360674 342193 -18481
Branches 52702 49340 -3362
============================================
- Hits 100605 71737 -28868
- Misses 246179 259981 +13802
+ Partials 13890 10475 -3415
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1774 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7578 |
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
button shows for domain admin; lgtm
Description
Fixes Snapshot copy, zone delete option not showing in UI for non-rootadmin roles.
We already use param in API call to filter backed up snapshot copies.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?