ui: Admin, account and project dashboard improvements #8193
Conversation
This backports only the dashboard changes from apache#7956 and 5d9ae31 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
requested review from
shwstppr,
DaanHoogland and
harikrishna-patnala
|
Have been missing the dashboard on 4.18 - backported it from main branch 1:1 changes esp only the CapacityDashboard.vue and UsageDashboard.vue changes and no changes in config.json etc. |
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
@rohityadavcloud looks fine but are we going to release a 4.18 maintenance release with this improvement? seems like it is only going to end up in 4.19 anyway. |
|
UI build: ✔️ |
|
@DaanHoogland the changes are already in main/4.19 - #7956 - since the changes are only in the UI - could benefit the community for if/when we do a 4.18.2.0 release. If you think it's probably not that useful I'm happy to close this (as I built a 4.18-based UI using this for my own benefit in my ACS homelab). |
Codecov Report
@@ Coverage Diff @@
## 4.18 #8193 +/- ##
============================================
+ Coverage 13.07% 13.09% +0.02%
- Complexity 9111 9122 +11
============================================
Files 2720 2720
Lines 257597 257603 +6
Branches 40160 40160
============================================
+ Hits 33680 33740 +60
+ Misses 219682 219598 -84
- Partials 4235 4265 +30 see 8 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
I don't object in any way, @rohityadavcloud . If it is convenient for you to merge, let's do it. |
|
Thanks Daan - I could still use two LGTMs cc @shwstppr @harikrishna-patnala @DaanHoogland |
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This backports only the dashboard changes from
#7956 and 5d9ae31