New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvm: fix ide controller for rocky/alma vms #8247
Conversation
...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8247 +/- ##
============================================
+ Coverage 13.10% 13.11% +0.01%
- Complexity 9122 9133 +11
============================================
Files 2720 2720
Lines 257638 257645 +7
Branches 40168 40171 +3
============================================
+ Hits 33753 33800 +47
+ Misses 219619 219554 -65
- Partials 4266 4291 +25 ☔ View full report in Codecov by Sentry. |
…/resource/LibvirtComputingResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>
@blueorangutan package |
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7842 |
@blueorangutan test |
@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
[SF] Trillian test result (tid-8402)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
I have manually tested this PR as well. However, I am the author of this PR, :-D |
deployed a vm on alma8:
@weizhouapache it is correct that the root disk is still on ide? |
root disk should be virtio disk as well |
ok, not in my test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
@DaanHoogland @weizhouapache is this good to go or are there some deviations in the manual tests here, #8247 (comment)? |
I did not investigate further why this happened. @weizhouapache can you comment? |
ok, this was layer 8 issue. I discussed with @weizhouapache off line and all lgtm @shwstppr |
* 4.18: kvm: fix ide controller for rocky/alma vms (#8247)
* 4.18: kvm: fix ide controller for rocky/alma vms (apache#8247)
* 4.18: kvm: fix ide controller for rocky/alma vms (apache#8247)
Description
This PR fixes ide controller for rocky/alma vms. virtio devices should be used.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?