Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include domain and account field for createTemplate UI form #8257

Merged
merged 2 commits into from Nov 28, 2023

Conversation

sudo87
Copy link
Contributor

@sudo87 sudo87 commented Nov 21, 2023

Description

This PR includes Domain and Account parameter in CreateTemplate form in UI for Admin account.
It will expose optional parameters domainId and account in UI supported by createTemplate API #8210

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot 2023-11-21 at 6 28 39 PM Screenshot 2023-11-21 at 6 32 04 PM

How Has This Been Tested?

  • Created u1 and u2 user under d1 and d2 domain respectively.
  • Create template form allows Admin user to provide domain and accountid
  • Template got created for right user account under correct domain

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (5c7e4b7) 29.16% compared to head (b95c9f3) 29.17%.

Files Patch % Lines
ui/src/views/storage/CreateTemplate.vue 0.00% 23 Missing ⚠️
ui/src/config/section/storage.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8257      +/-   ##
============================================
+ Coverage     29.16%   29.17%   +0.01%     
- Complexity    31064    31081      +17     
============================================
  Files          5193     5193              
  Lines        366292   366320      +28     
  Branches      53555    53559       +4     
============================================
+ Hits         106816   106872      +56     
+ Misses       244832   244813      -19     
+ Partials      14644    14635       -9     
Flag Coverage Δ
simulator-marvin-tests 25.13% <ø> (+0.02%) ⬆️
uitests 4.49% <0.00%> (-0.01%) ⬇️
unit-tests 14.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohityadavcloud rohityadavcloud added this to the 4.19.0.0 milestone Nov 27, 2023
@apache apache deleted a comment from blueorangutan Nov 27, 2023
@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8257 (QA-JID-233)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM
checked in qa with two different domains/users

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a simulator env,
Screenshot from 2023-11-28 13-30-42

@shwstppr shwstppr merged commit b0a9949 into apache:main Nov 28, 2023
25 of 26 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 29, 2023
…#8257)

This PR includes Domain and Account parameters in CreateTemplate form in UI for Admin account.
It will expose optional parameters domainId and account in UI supported by createTemplate API apache#8210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants