kvm: ITCO watchdog added

[DaanHoogland]

Description

This PR, ...

Fixes: #8280

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

come to think of it, this is probably not the only thing needed. If anyone knows... ?

[weizhouapache]

come to think of it, this is probably not the only thing needed. If anyone knows... ?

@DaanHoogland
create a RHEL 9 env and test it ?

[blueorangutan]

@DaanHoogland [SL] unsupported parameters provided. Supported mgmt server os are: centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

[DaanHoogland]

$%#
@blueorangutan test alma9 kvm-alma9 keepEnv

[weizhouapache]

code lgtm

need testing

[weizhouapache]

Assigned to myself. I will test it @DaanHoogland @shwstppr

[weizhouapache]

tried to configure watchdog on kvm host, but no success.

anyway, I think this is good to go. According to libvirt, itco is a valid model for watchdog.
https://libvirt.org/formatdomain.html#watchdog-devices

@DaanHoogland
maybe we could add new action inject-nmi as well.

cc @shwstppr

[DaanHoogland]

@DaanHoogland maybe we could add new action inject-nmi as well.

seems like a new PR, would you suggest a API/UI enhancement for that? (creating #8368)

[weizhouapache]

@DaanHoogland maybe we could add new action inject-nmi as well.

seems like a new PR, would you suggest a API/UI enhancement for that? (creating #8368)

no, just a new option for action (which is set by vm.watchdog.action in agent.properties).
you can update this PR to support it as well.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb2b6ac) 13.11% compared to head (35e3b11) 13.16%.
Report is 27 commits behind head on 4.18.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.18    #8282      +/-   ##
============================================
+ Coverage     13.11%   13.16%   +0.04%     
- Complexity     9133     9201      +68     
============================================
  Files          2720     2724       +4     
  Lines        257659   258087     +428     
  Branches      40171    40223      +52     
============================================
+ Hits          33802    33984     +182     
- Misses       219566   219797     +231     
- Partials       4291     4306      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

code lgtm

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8519

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[weizhouapache]

I was not able to test it. (ITCO is unsupported on my kvm hosts)

I do not see any error or risk to merge this PR.
what do you think ? @DaanHoogland @rohityadavcloud @shwstppr @JoaoJandre

[DaanHoogland]

just to be sure
@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9146)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46187 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8282-t9146-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[rahultolearn59]

hi @DaanHoogland, I have experienced the same error with RHEL9 KVM as well with ACS 4.19. Can we get this merged to 4.19 as well?

[weizhouapache]

@rahultolearn59

All commits in 4.18 will be merged into 4.19 and main branch