Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements on migration in the VmwareResource #8300

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Logging improvements on migration in the VmwareResource #8300

merged 3 commits into from
Feb 28, 2024

Conversation

DaanHoogland
Copy link
Contributor

Description

This PR,..

Fixes: #8291

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e47a910) 13.16% compared to head (f99ff13) 13.16%.

Files Patch % Lines
...oud/hypervisor/vmware/resource/VmwareResource.java 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.18    #8300      +/-   ##
============================================
- Coverage     13.16%   13.16%   -0.01%     
  Complexity     9203     9203              
============================================
  Files          2724     2724              
  Lines        258120   258127       +7     
  Branches      40231    40234       +3     
============================================
  Hits          33989    33989              
- Misses       219823   219830       +7     
  Partials       4308     4308

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland changed the title Loggoing improvements on migration in the VmwareResource Logging improvements on migration in the VmwareResource Dec 5, 2023
@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache
weizhouapache reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland
is this ready for review ?

@weizhouapache
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8057

@DaanHoogland DaanHoogland marked this pull request as ready for review December 15, 2023 09:47
@DaanHoogland DaanHoogland added this to the 4.18.2.0 milestone Dec 18, 2023
@DaanHoogland
Copy link
Contributor Author

@blueorangutan test alma9 vmware-70u3

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-8618)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9
Total time taken: 47084 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8300-t8618-vmware-70u3.zip
Smoke tests completed. 106 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_05_ping_in_cpvm_success Error 1.12 test_diagnostics.py
test_06_ping_in_cpvm_failure Error 1.11 test_diagnostics.py
test_12_traceroute_in_cpvm Error 1.11 test_diagnostics.py
test_17_retrieve_cpvm_default_files Error 1.11 test_diagnostics.py
test_18_retrieve_cpvm_single_file Error 1.12 test_diagnostics.py
test_01_add_primary_storage_disabled_host Error 36.25 test_primary_storage.py
test_01_non_strict_host_anti_affinity Failure 147.21 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 107.25 test_nonstrict_affinity_group.py

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8518

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test alma9 vmware-70u3

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-9092)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9
Total time taken: 49798 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8300-t9092-vmware-70u3.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@vishesh92
Copy link
Member

clgtm. Just a small suggestion.

@rohityadavcloud
Copy link
Member

Not ready for merge, if changes are made and not packages/tested
@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8636

@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8641

@DaanHoogland
Copy link
Contributor Author

Not ready for merge, if changes are made and not packages/tested @blueorangutan package

the changes on that last commit were only textual and the GHA for build was succesful. I think it was ready for merge.

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled withthe changes on that last commit were only textual and the GHA for build was succesful. I think it was ready for merge. SystemVM template(s). I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8643

@vishesh92
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-9206)

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-9212)

@vishesh92
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8660

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test alma9 vmware-70u3

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-9230)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9
Total time taken: 47376 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8300-t9230-vmware-70u3.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_redundant_vpc_site2site_vpn Error 512.78 test_vpc_vpn.py

@vishesh92 vishesh92 merged commit 56e0450 into apache:4.18 Feb 28, 2024
24 of 27 checks passed
@vishesh92 vishesh92 deleted the vmwareLoggingInMigrateCommand branch February 28, 2024 09:59
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 5, 2024
@DaanHoogland @dhslove
Logging improvements on migration in the VmwareResource (apache#8300)
7bf2223
@DaanHoogland DaanHoogland mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

@vladimirpetrov vladimirpetrov

Labels
component:logging component:vmware status:ready-for-merge
Projects
None yet
Milestone
4.18.2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@DaanHoogland @blueorangutan @weizhouapache @rohityadavcloud @vishesh92 @vladimirpetrov