Allow autoscale group and name override

[rg9975]

… conventions

Description

Updates AutoScaleManager/AutoScaleManagerImpl so that getNextVmHostName and checkAutoScaleVmGroupName can be overridden in derivative implementations to allow for custom naming conditions and restrictions. If possible, would like to include this in 4.19 since it is a trivial change.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Extended implementation class with different VM names and tested for shorter auto-scale names.

How did you try to break this feature and the system with this change?

Use group names longer than the extended code allowed.

[weizhouapache]

@rg9975
it is trivial indeed. can you give more details how you will use the method ?

[rg9975]

We create an extension of AutoScaleManagerImpl.java, override these 2 methods, and override the spring-server-core-managers-context.xml to set the value of the manager to our extension class:

<bean id="autoScaleManagerImpl" class="com......CustomAutoScaleManagerImpl" />

This allows us to deploy local changes that may not make sense for Cloudstack submission. In this case, very specific naming size and format requirements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6001772) 29.13% compared to head (f3c37b7) 29.15%.
Report is 34 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8324      +/-   ##
============================================
+ Coverage     29.13%   29.15%   +0.02%     
- Complexity    31026    31269     +243     
============================================
  Files          5193     5251      +58     
  Lines        366232   368802    +2570     
  Branches      53546    53767     +221     
============================================
+ Hits         106692   107524     +832     
- Misses       244918   246564    +1646     
- Partials      14622    14714      +92     

Flag	Coverage Δ
simulator-marvin-tests	25.04% <ø> (-0.03%)	⬇️
uitests	4.44% <ø> (-0.05%)	⬇️
unit-tests	14.89% <ø> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weizhouapache]

We create an extension of AutoScaleManagerImpl.java, override these 2 methods, and override the spring-server-core-managers-context.xml to set the value of the manager to our extension class:

<bean id="autoScaleManagerImpl" class="com......CustomAutoScaleManagerImpl" />

This allows us to deploy local changes that may not make sense for Cloudstack submission. In this case, very specific naming size and format requirements.

@rg9975
thanks, looks ok to me

[shwstppr]

LGTM

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7966

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-8505)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49697 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8324-t8505-kvm-centos7.zip
Smoke tests completed. 118 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	Failure	0.03	test_ssvm.py
test_04_cpvm_internals	Failure	0.04	test_ssvm.py
test_02_trigger_shutdown	Failure	336.69	test_safe_shutdown.py
test_08_upgrade_kubernetes_ha_cluster	Failure	748.78	test_kubernetes_clusters.py

[boring-cyborg]

Awesome work, congrats on your first merged pull request!