Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded duplicate words #8358

Merged
merged 1 commit into from Dec 15, 2023

Conversation

jbampton
Copy link
Member

Description

This PR removes some unneeded duplicate words.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0bc7fb5) 30.75% compared to head (d89ca9b) 30.79%.

Files Patch % Lines
...tack/engine/orchestration/NetworkOrchestrator.java 0.00% 1 Missing ⚠️
...oud/hypervisor/vmware/resource/VmwareResource.java 0.00% 1 Missing ⚠️
...cloud/storage/resource/VmwareStorageProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8358      +/-   ##
============================================
+ Coverage     30.75%   30.79%   +0.04%     
- Complexity    33910    33958      +48     
============================================
  Files          5341     5341              
  Lines        374759   374759              
  Branches      54510    54510              
============================================
+ Hits         115248   115417     +169     
+ Misses       244276   244093     -183     
- Partials      15235    15249      +14     
Flag Coverage Δ
simulator-marvin-tests 24.72% <0.00%> (+0.07%) ⬆️
uitests 4.40% <ø> (ø)
unit-tests 16.44% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8062

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaanHoogland
Copy link
Contributor

@shwstppr this is only log messages, parameter descriptors and comments. I think we can include this.

@shwstppr shwstppr added this to the 4.19.0.0 milestone Dec 15, 2023
@shwstppr shwstppr merged commit dda6725 into apache:main Dec 15, 2023
24 of 25 checks passed
@jbampton jbampton deleted the remove-duplicate-words branch December 16, 2023 10:49
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 27, 2023
This PR removes some unneeded duplicate words.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants