New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix layout for action button for template form #8434
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8434 +/- ##
=========================================
Coverage 30.80% 30.80%
- Complexity 33981 33987 +6
=========================================
Files 5341 5341
Lines 374864 374864
Branches 54518 54518
=========================================
+ Hits 115485 115491 +6
Misses 244114 244114
+ Partials 15265 15259 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
tested with https://qa.cloudstack.cloud/simulator/pr/8434
Also reproduced the issue with old qa servers.
Fixes layout for the action buttons on register template form Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Description
Fixes layout for the action buttons on register template form
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
How did you try to break this feature and the system with this change?