Fix Vmware to KVM migration issue #8485
Conversation
nvazquez
requested review from
shwstppr,
DaanHoogland,
harikrishna-patnala,
Pearl1594,
borisstoyanov,
andrijapanicsb and
weizhouapache
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8485 +/- ##
============================================
+ Coverage 30.74% 30.76% +0.01%
- Complexity 33930 33943 +13
============================================
Files 5341 5341
Lines 374918 374918
Branches 54534 54534
============================================
+ Hits 115286 115360 +74
+ Misses 244374 244306 -68
+ Partials 15258 15252 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8260 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
| @@ -1111,7 +1111,7 @@ private UserVm importVirtualMachineInternal(final UnmanagedInstanceTO unmanagedI | |||
| } | |||
| } | |||
| allDetails.put(VmDetailConstants.ROOT_DISK_CONTROLLER, rootDisk.getController()); | |||
| if (cluster.getHypervisorType() != Hypervisor.HypervisorType.VMware) { | |||
| if (cluster.getHypervisorType() == Hypervisor.HypervisorType.KVM && isImportUnmanagedFromSameHypervisor) { | |||
| allDetails.put(VmDetailConstants.ROOT_DISK_SIZE, String.valueOf(rootDisk.getCapacity() / Resource.ResourceType.bytesToGiB)); | |||
There was a problem hiding this comment.
@nvazquez I think we need to here make sure the minimum is 1. i.e.
| allDetails.put(VmDetailConstants.ROOT_DISK_SIZE, String.valueOf(rootDisk.getCapacity() / Resource.ResourceType.bytesToGiB)); | |
| long size = rootDisk.getCapacity() / Resource.ResourceType.bytesToGiB; | |
| if (size <= 0) { | |
| size = 1; | |
| } | |
| allDetails.put(VmDetailConstants.ROOT_DISK_SIZE, String.valueOf(size)); |
There was a problem hiding this comment.
i added this to #8488 so ignore here and now
|
[SF] Trillian test result (tid-8776)
|
|
Test failures are env related with one hypervisor host remaining in connecting state |
This PR fixes the Vmware to KVM migration issue on main branch Fixes: apache#8473
Description
This PR fixes the Vmware to KVM migration issue on main branch
Fixes: #8473
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?