ui: fix labels when migrating instances from vmware

[shwstppr]

Description

Fixes #8474
Renames labels when importing from VMware

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

ui-instances-label.mp4

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4d42b8d) 4.39% compared to head (a47955b) 30.78%.
Report is 4 commits behind head on main.

Files	Patch %	Lines
ui/src/views/tools/ManageInstances.vue	0.00%	1 Missing ⚠️
ui/src/views/tools/SelectVmwareVcenter.vue	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              main    #8490       +/-   ##
============================================
+ Coverage     4.39%   30.78%   +26.39%     
- Complexity       0    33978    +33978     
============================================
  Files          361     5341     +4980     
  Lines        28622   374942   +346320     
  Branches      4993    54538    +49545     
============================================
+ Hits          1258   115440   +114182     
- Misses       27225   244240   +217015     
- Partials       139    15262    +15123     

Flag	Coverage Δ
simulator-marvin-tests	24.69% <ø> (?)
uitests	4.39% <0.00%> (-0.01%)	⬇️
unit-tests	16.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nvazquez]

Code LGTM

[nvazquez]

@blueorangutan ui

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8490 (QA-JID-260)

[DaanHoogland]

clgtm

[DaanHoogland]

shouldn't isMigrateFromVmware be enough condition? i.e.

Suggested change

	{{ (isMigrateFromVmware && vmwareVcenterType === 'existing') ? $t('label.instances') : $t('label.unmanaged.instances') }}
	<a-tooltip :title="(isMigrateFromVmware && vmwareVcenterType === 'existing') ? $t('message.instances.migrate.vmware') : $t('message.instances.unmanaged')">
	{{ isMigrateFromVmware ? $t('label.instances') : $t('label.unmanaged.instances') }}
	<a-tooltip :title="isMigrateFromVmware ? $t('message.instances.migrate.vmware') : $t('message.instances.unmanaged')">

[shwstppr]

@DaanHoogland current change allows showing Instances label only when the vCenter is an existing one. External vCenter will always considered to have unmanaged instances

[DaanHoogland]

yes but the label doesn't have to change for that, that's my point.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8271

[rajujith]

LGTM.