Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: use ed25519 instead of rsa when generate public/private keys #8549

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

weizhouapache
Copy link
Member

Description

RSA has been considered as insecure and 'ssh-rsa' signature algorithm has been deprecated in OpenSSH.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

RSA has been considered as insecure and 'ssh-rsa' signature algorithm has been deprecated in OpenSSH.
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (33bb92a) 13.16% compared to head (702f4a5) 13.16%.

Files Patch % Lines
...java/com/cloud/server/ConfigurationServerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.18    #8549   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
  Complexity     9201     9201           
=========================================
  Files          2724     2724           
  Lines        258077   258077           
  Branches      40224    40224           
=========================================
  Hits          33981    33981           
  Misses       219790   219790           
  Partials       4306     4306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8414

@DaanHoogland
Copy link
Contributor

@blueorangutan test matrix

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm (functionality as well ;)

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@blueorangutan
Copy link

[SF] Trillian test result (tid-8915)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43230 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8549-t8915-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[SF] Trillian test result (tid-8913)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47080 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8549-t8913-xenserver-71.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_volume_usage Error 83.27 test_usage.py

@rohityadavcloud rohityadavcloud merged commit 1d5230b into apache:4.18 Feb 5, 2024
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the 4.18-server-ed25519 branch February 6, 2024 08:01
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Feb 7, 2024
…pache#8549)

RSA has been considered as insecure and 'ssh-rsa' signature algorithm has been deprecated in OpenSSH.
weizhouapache added a commit to weizhouapache/cloudstack that referenced this pull request Feb 23, 2024
…pache#8549)

RSA has been considered as insecure and 'ssh-rsa' signature algorithm has been deprecated in OpenSSH.
weizhouapache added a commit to weizhouapache/cloudstack that referenced this pull request Feb 28, 2024
PR apache#8549 replaced RSA with ed25519. unfornately, ed25519 is unsupported in FIPS mode

```
$  ssh-keygen -t ed25519 -m PEM -N '' -f key1
ED25519 keys are not allowed in FIPS mode

$  ssh-keygen -t ecdsa -m PEM -N '' -f key1
Generating public/private ecdsa key pair.
Your identification has been saved in key1
Your public key has been saved in key1.pub
The key fingerprint is:
.........

```
weizhouapache added a commit that referenced this pull request Mar 3, 2024
#8719)

PR #8549 replaced RSA with ed25519. unfornately, ed25519 is unsupported in FIPS mode

```
$  ssh-keygen -t ed25519 -m PEM -N '' -f key1
ED25519 keys are not allowed in FIPS mode

$  ssh-keygen -t ecdsa -m PEM -N '' -f key1
Generating public/private ecdsa key pair.
Your identification has been saved in key1
Your public key has been saved in key1.pub
The key fingerprint is:
.........

```
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 5, 2024
apache#8719)

PR apache#8549 replaced RSA with ed25519. unfornately, ed25519 is unsupported in FIPS mode

```
$  ssh-keygen -t ed25519 -m PEM -N '' -f key1
ED25519 keys are not allowed in FIPS mode

$  ssh-keygen -t ecdsa -m PEM -N '' -f key1
Generating public/private ecdsa key pair.
Your identification has been saved in key1
Your public key has been saved in key1.pub
The key fingerprint is:
.........

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants