-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing metrics English locale strings #8560
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8560 +/- ##
=============================================
+ Coverage 13.16% 30.77% +17.60%
- Complexity 9201 33968 +24767
=============================================
Files 2724 5341 +2617
Lines 258077 375027 +116950
Branches 40224 54554 +14330
=============================================
+ Hits 33981 115415 +81434
- Misses 219790 244350 +24560
- Partials 4306 15262 +10956
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@kohrar this needs to be targetted to 4.18 branch if you would want it to go in 4.18.2 cc @JoaoJandre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested in qa
@sureshanaparti this is based on main so I changed the milestone to 4.20. |
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
@DaanHoogland Thanks. I didn't realize I targetted main. I'll keep that in mind in the future. I've created a new PR (#8564) that targets 4.18. Is this the correct approach? |
We don't have to create two PRs for two branches @kohrar. You can simply rebase this current branch with 4.18 (or force push to add_missing_en_locale) and change the apache:main to apache:4.18 in this PR itself. |
7eca5b1
to
874daba
Compare
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
😅 Thanks for the pointer. It took me a little too long to figure out how to change the PR to target 4.18 on GitHub. I hope that I got it right now! |
retesting; |
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
* Update ui/public/locales/en.json Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> * Update ui/public/locales/en.json Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> --------- Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
Description
This PR fixes two missing English locale strings that are missing in the metrics page in 4.18.1.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Rebuilt UI
How did you try to break this feature and the system with this change?
Trivial change and should not have any other side effects.