Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] NSX: Fix VPC routed mode #8561

Closed
wants to merge 1 commit into from

Conversation

Pearl1594
Copy link
Contributor

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (80365c8) 30.07% compared to head (588bf63) 30.99%.
Report is 11 commits behind head on nsx-integration.

Files Patch % Lines
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             nsx-integration    #8561      +/-   ##
=====================================================
+ Coverage              30.07%   30.99%   +0.92%     
+ Complexity             33323    31899    -1424     
=====================================================
  Files                   5377     5016     -361     
  Lines                 377958   349281   -28677     
  Branches               54939    49917    -5022     
=====================================================
- Hits                  113673   108270    -5403     
+ Misses                249177   226428   -22749     
+ Partials               15108    14583     -525     
Flag Coverage Δ
simulator-marvin-tests 21.90% <33.33%> (-1.55%) ⬇️
uitests ?
unit-tests 16.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 3, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@nvazquez nvazquez closed this Feb 10, 2024
@DaanHoogland DaanHoogland added this to the unplanned milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants