-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: bundle cmk in cloudstack-management package #8574
Conversation
This bundles latest cmk release in cloudstack-management package, so admins won't need to install it for typical first-install use. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@blueorangutan package |
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8574 +/- ##
============================================
- Coverage 30.82% 23.00% -7.82%
+ Complexity 34014 23766 -10248
============================================
Files 5341 5209 -132
Lines 375027 352985 -22042
Branches 54554 50562 -3992
============================================
- Hits 115592 81196 -34396
- Misses 244155 260139 +15984
+ Partials 15280 11650 -3630
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@rohityadavcloud how can we install a management server without cmk? or is it the intention that this is no longer possible? |
@DaanHoogland sorry, I don't understand your question. The PR intends to bundle cmk with the cloudstack-management pkg, this was a popular QA/admin request. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8470 |
with this change, cmk will always be installed on mgmt server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
/usr/bin/cmk
will be overwritted if it already exists, right ?
@weizhouapache unfortunately if /usr/bin/cmk exists then yes, it will be overwritten by cloudstack-management pkg provided CLI. If you'd prefer, I can create a new rpm/deb pkg called cloudstack-cli that bundles/installs cmk ? |
@rohityadavcloud |
well, not a 👎 but I think it should be installed separately. |
currently it is.
|
@blueorangutan package |
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8523 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with OL8 and Ubuntu22
The cmk package is installed under /usr/bin/cmk and the tool is working fine
Loaded in-built API cache. Failed to read API cache, please run 'sync'.
Apache CloudStack 🐵 CloudMonkey 6.3.0
Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues
(localcloud) 🐱 > list zones
{
"count": 1,
"zone": [
{
"allocationstate": "Enabled",
"allowuserspecifyvrmtu": false,
"dhcpprovider": "VirtualRouter",
"dns1": "10.0.32.1",
"dns2": "8.8.8.8",
"guestcidraddress": "10.1.1.0/24",
"hasannotations": false,
"id": "7f08660c-443c-4351-88c4-611d44961bc6",
"internaldns1": "10.0.32.1",
"internaldns2": "8.8.4.4",
"localstorageenabled": false,
"name": "ref-trl-6320-k-Mu22-kiran-chavala",
"networktype": "Advanced",
"routerprivateinterfacemaxmtu": 1500,
"routerpublicinterfacemaxmtu": 1500,
"securitygroupsenabled": false,
"tags": [],
"type": "Core",
"zonetoken": "037b5229-490e-3dd9-9343-58e1c1088699"
}
]
}
(l
merging based on approvals and manua testing |
This bundles latest cmk release in cloudstack-management package, so admins won't need to install it for typical first-install use. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This bundles latest cmk release in cloudstack-management package, so admins won't need to install it for typical first-install use.
Types of changes