-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: fix icmp code/type of ACL rule are not display if the value is -1 #8589
UI: fix icmp code/type of ACL rule are not display if the value is -1 #8589
Conversation
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8589 +/- ##
=========================================
Coverage 13.16% 13.16%
Complexity 9201 9201
=========================================
Files 2724 2724
Lines 258087 258087
Branches 40223 40223
=========================================
Hits 33984 33984
Misses 219797 219797
Partials 4306 4306 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR fixes #8583
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?