VR: fix issue between VPC VMs and other Public IPs in the same subnet as additional Public IPs

[weizhouapache]

Description

This PR fixes #8562

If there are mutliple public subnets in a VR, there should be iptables rules like

-A POSTROUTING -o eth1 -j SNAT --to-source <Source NAT IP>
-A POSTROUTING -o eth3 -j SNAT --to-source <Source NAT IP>
-A POSTROUTING -o ethX -j SNAT --to-source <Source NAT IP>

in VR of isolated networks, these rules do exist.
Howver in VPC VR, only the first rule exists, the other rules are missing

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b34f093) 13.16% compared to head (894995c) 13.16%.
Report is 5 commits behind head on 4.18.

❗ Current head 894995c differs from pull request most recent head 9236d16. Consider uploading reports for the commit 9236d16 to get more accurate results

Files	Patch %	Lines
...ork/router/VirtualNetworkApplianceManagerImpl.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.18    #8599      +/-   ##
============================================
- Coverage     13.16%   13.16%   -0.01%     
+ Complexity     9203     9201       -2     
============================================
  Files          2724     2724              
  Lines        258087   258091       +4     
  Branches      40223    40225       +2     
============================================
- Hits          33987    33984       -3     
- Misses       219793   219801       +8     
+ Partials       4307     4306       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8494

[weizhouapache]

@blueorangutan test rocky8 kvm-rocky8

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[sureshanaparti]

code lgtm

[DaanHoogland]

clgtm

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8601

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9141)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8599-t9141-kvm-centos7.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	Error	0.06	test_vm_life_cycle.py