Linstor fix migration while node offline #8610
Conversation
If a Linstor node is down while migrating resource, allow-two-primaries setting will fail because we can't reach the downed node. But it will still set the property on the other nodes and migration should work. We now just report an error instead of completely failing.
rp-
force-pushed
the
linstor-fix-migration-while-node-offline
branch
from
83730d2
to
1f6954c
Compare
|
Commit: 1f6954c should also be applied to 4.19 and main |
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
@rp- any case returns false (on error / exception above ?)
There was a problem hiding this comment.
AFAIS every upper caller is ignoring the return value anyway
But we don't need to do any disconnect, it is just a bit of a tidy up to remove the property and nothing fatal if it fails.
Entire PR changes can be forward merged to 4.19 / main. I think, merge excludes other changes if there are already in. |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Merged based on smoketests. All changes in Linstor plugin. |
* linstor: Add util method getBestErrorMessage from main * linstor: failed remove of allow-two-primaries is no fatal error * linstor: Fix failure if a Linstor node is down while migrating If a Linstor node is down while migrating resource, allow-two-primaries setting will fail because we can't reach the downed node. But it will still set the property on the other nodes and migration should work. We now just report an error instead of completely failing.
* linstor: Add util method getBestErrorMessage from main * linstor: failed remove of allow-two-primaries is no fatal error * linstor: Fix failure if a Linstor node is down while migrating If a Linstor node is down while migrating resource, allow-two-primaries setting will fail because we can't reach the downed node. But it will still set the property on the other nodes and migration should work. We now just report an error instead of completely failing.
Description
If a Linstor node is down while migrating resource, allow-two-primaries
setting will fail because we can't reach the downed node. But it will
still set the property on the other nodes and migration should work.
We now just report an error instead of completely failing.
This PR also containes a cherry-picked commit from the main branch f176e7d
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Nested Linstor cluster with a non hyperconverged setup and a node evicted.
How did you try to break this feature and the system with this change?