server: fix fail to list public ips of shared networks sometimes #8624

weizhouapache · 2024-02-07T13:41:41Z

Description

This PR fixes #8622

error

2024-02-07 10:59:11,110 ERROR [c.c.a.ApiServer] (qtp1146825051-20:ctx-74413901 ctx-b91ecc51) (logid:aa41ab63) unhandled exception executing api command: [Ljava.lang.String;@5a46b058
java.lang.NullPointerException
    at com.cloud.vm.NicVO.getInstanceId(NicVO.java:256)
    at com.cloud.api.ApiResponseHelper.addSystemVmInfoToIpResponse(ApiResponseHelper.java:995)
    at com.cloud.api.ApiResponseHelper.showVmInfoForSharedNetworks(ApiResponseHelper.java:1175)
    at com.cloud.api.ApiResponseHelper.createIPAddressResponse(ApiResponseHelper.java:1088)
    at org.apache.cloudstack.api.command.user.address.ListPublicIpAddressesCmd.execute(ListPublicIpAddressesCmd.java:196)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

error ``` 2024-02-07 10:59:11,110 ERROR [c.c.a.ApiServer] (qtp1146825051-20:ctx-74413901 ctx-b91ecc51) (logid:aa41ab63) unhandled exception executing api command: [Ljava.lang.String;@5a46b058 java.lang.NullPointerException at com.cloud.vm.NicVO.getInstanceId(NicVO.java:256) at com.cloud.api.ApiResponseHelper.addSystemVmInfoToIpResponse(ApiResponseHelper.java:995) at com.cloud.api.ApiResponseHelper.showVmInfoForSharedNetworks(ApiResponseHelper.java:1175) at com.cloud.api.ApiResponseHelper.createIPAddressResponse(ApiResponseHelper.java:1088) at org.apache.cloudstack.api.command.user.address.ListPublicIpAddressesCmd.execute(ListPublicIpAddressesCmd.java:196) ```

codecov · 2024-02-07T13:50:07Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0d36098) 30.75% compared to head (9855c1c) 30.95%.
Report is 11 commits behind head on 4.19.

Files	Patch %	Lines
...src/main/java/com/cloud/api/ApiResponseHelper.java	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8624      +/-   ##
============================================
+ Coverage     30.75%   30.95%   +0.20%     
- Complexity    33964    34220     +256     
============================================
  Files          5346     5346              
  Lines        375435   375447      +12     
  Branches      54603    54606       +3     
============================================
+ Hits         115460   116218     +758     
+ Misses       244742   243914     -828     
- Partials      15233    15315      +82

Flag	Coverage Δ
simulator-marvin-tests	`24.85% <0.00%> (+0.33%)`	⬆️
uitests	`4.39% <ø> (ø)`
unit-tests	`16.54% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/src/main/java/com/cloud/api/ApiResponseHelper.java

DaanHoogland

clgtm

DaanHoogland · 2024-02-09T14:07:54Z

@blueorangutan package

blueorangutan · 2024-02-09T14:10:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-09T15:10:37Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8612

server/src/main/java/com/cloud/api/ApiResponseHelper.java

weizhouapache · 2024-02-09T17:02:07Z

@blueorangutan package

blueorangutan · 2024-02-09T17:04:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-09T18:05:24Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8613

…Long

weizhouapache · 2024-02-12T13:45:59Z

@blueorangutan package

blueorangutan · 2024-02-12T13:48:05Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-12T14:47:07Z

Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 8631

weizhouapache · 2024-02-12T14:58:17Z

@blueorangutan package

blueorangutan · 2024-02-12T15:00:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-12T16:01:47Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8633

rohityadavcloud · 2024-02-13T05:40:40Z

@blueorangutan test

blueorangutan · 2024-02-13T05:42:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-02-13T18:09:23Z

[SF] Trillian test result (tid-9185)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43343 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8624-t9185-kvm-centos7.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_network_operations_on_created_vm_of_otheruser	`Failure`	120.38	test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	120.39	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.34	test_network_permissions.py
test_01_nic	`Error`	200.61	test_nic.py
test_02_trigger_shutdown	`Failure`	336.78	test_safe_shutdown.py

rohityadavcloud · 2024-03-08T08:24:06Z

@blueorangutan test

blueorangutan · 2024-03-08T08:26:07Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-03-08T23:35:56Z

[SF] Trillian test result (tid-9429)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53035 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8624-t9429-kvm-centos7.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_network_operations_on_created_vm_of_otheruser	`Failure`	125.36	test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	125.37	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.40	test_network_permissions.py
test_01_nic	`Error`	203.30	test_nic.py
test_02_trigger_shutdown	`Failure`	336.87	test_safe_shutdown.py

shwstppr · 2024-05-22T10:25:34Z

@weizhouapache unless I'm missing the point, even if we decide on wrapping nic.getInstanceId() in a try-catch for NPE it would still need changes in many more places

weizhouapache · 2024-05-22T10:51:48Z

@weizhouapache unless I'm missing the point, even if we decide on wrapping nic.getInstanceId() in a try-catch for NPE it would still need changes in many more places

if change the type from integer to Integer, yes
but if the type is still integer, no more changes is needed.

…ips-shared-network

weizhouapache · 2024-05-22T10:55:21Z

@blueorangutan package

blueorangutan · 2024-05-22T10:56:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-05-22T12:04:35Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9668

blueorangutan · 2024-05-22T21:27:54Z

[SF] Trillian test result (tid-10239)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46013 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8624-t10239-kvm-centos7.zip
Smoke tests completed. 129 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	414.13	test_events_resource.py
test_01_redundant_vpc_site2site_vpn	`Failure`	420.75	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	343.12	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	294.82	test_vpc_vpn.py

shwstppr · 2024-05-28T07:06:10Z

@DaanHoogland @weizhouapache is this good to merge?

DaanHoogland · 2024-05-28T07:30:12Z

let's make sure it doesn't cause the integration test failures

DaanHoogland · 2024-05-28T07:30:19Z

@blueorangutan package

blueorangutan · 2024-05-28T07:32:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-05-28T08:06:54Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9719

weizhouapache · 2024-05-28T09:29:19Z

@blueorangutan package

blueorangutan · 2024-05-28T09:30:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-05-28T10:41:55Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9721

weizhouapache · 2024-05-28T12:34:00Z

@blueorangutan test

blueorangutan · 2024-05-28T12:36:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-05-29T01:21:30Z

[SF] Trillian test result (tid-10308)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44310 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8624-t10308-kvm-centos7.zip
Smoke tests completed. 129 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	`Failure`	341.81	test_safe_shutdown.py
test_05_vmschedule_test_e2e	`Failure`	361.85	test_vm_schedule.py

weizhouapache added this to the 4.19.1.0 milestone Feb 7, 2024

weizhouapache linked an issue Feb 7, 2024 that may be closed by this pull request

Change IP address for NIC or add secondary - IPs not visible - 4.19 #8622

Closed

DaanHoogland reviewed Feb 7, 2024

View reviewed changes

server/src/main/java/com/cloud/api/ApiResponseHelper.java Outdated Show resolved Hide resolved

DaanHoogland approved these changes Feb 9, 2024

View reviewed changes

DaanHoogland added the status:needs-testing label Feb 9, 2024

weizhouapache commented Feb 9, 2024

View reviewed changes

server/src/main/java/com/cloud/api/ApiResponseHelper.java Outdated Show resolved Hide resolved

Update server/src/main/java/com/cloud/api/ApiResponseHelper.java

c426a19

Update PR#8624: change return type of Nic.getInstanceId from long to …

9855c1c

…Long

boring-cyborg bot added the component:api label Feb 12, 2024

rohityadavcloud approved these changes Feb 13, 2024

View reviewed changes

weizhouapache added 3 commits May 22, 2024 12:53

Merge remote-tracking branch 'apache/4.19' into 4.19-fix-list-public-…

71efef6

…ips-shared-network

Revert all changes

e9a02ef

Update 8624: new fix

4f6ed22

weizhouapache force-pushed the 4.19-fix-list-public-ips-shared-network branch from 31c9bc3 to 4f6ed22 Compare May 22, 2024 10:54

shwstppr requested a review from vishesh92 May 28, 2024 07:06

DaanHoogland closed this May 28, 2024

DaanHoogland reopened this May 28, 2024

DaanHoogland linked an issue May 31, 2024 that may be closed by this pull request

Guest network not consistently displaying free and allocated addresses #9101

Closed

DaanHoogland closed this Jun 3, 2024

DaanHoogland reopened this Jun 3, 2024

DaanHoogland merged commit 875cd14 into apache:4.19 Jun 4, 2024
70 of 72 checks passed

DaanHoogland deleted the 4.19-fix-list-public-ips-shared-network branch June 4, 2024 07:28

DaanHoogland mentioned this pull request Jun 4, 2024

Change IP address for NIC or add secondary - IPs not visible - 4.19 #8622

Closed

server: fix fail to list public ips of shared networks sometimes #8624

server: fix fail to list public ips of shared networks sometimes #8624

Conversation

weizhouapache commented Feb 7, 2024 • edited

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov bot commented Feb 7, 2024 • edited

Codecov Report

DaanHoogland left a comment

Choose a reason for hiding this comment

DaanHoogland commented Feb 9, 2024

blueorangutan commented Feb 9, 2024

blueorangutan commented Feb 9, 2024

weizhouapache commented Feb 9, 2024

blueorangutan commented Feb 9, 2024

blueorangutan commented Feb 9, 2024

weizhouapache commented Feb 12, 2024

blueorangutan commented Feb 12, 2024

blueorangutan commented Feb 12, 2024

weizhouapache commented Feb 12, 2024

blueorangutan commented Feb 12, 2024

blueorangutan commented Feb 12, 2024

rohityadavcloud commented Feb 13, 2024

blueorangutan commented Feb 13, 2024

blueorangutan commented Feb 13, 2024

rohityadavcloud commented Mar 8, 2024

blueorangutan commented Mar 8, 2024

blueorangutan commented Mar 8, 2024

shwstppr commented May 22, 2024

weizhouapache commented May 22, 2024

weizhouapache commented May 22, 2024

blueorangutan commented May 22, 2024

blueorangutan commented May 22, 2024

blueorangutan commented May 22, 2024

shwstppr commented May 28, 2024

DaanHoogland commented May 28, 2024

DaanHoogland commented May 28, 2024

blueorangutan commented May 28, 2024

blueorangutan commented May 28, 2024

weizhouapache commented May 28, 2024

blueorangutan commented May 28, 2024

blueorangutan commented May 28, 2024

weizhouapache commented May 28, 2024

blueorangutan commented May 28, 2024

blueorangutan commented May 29, 2024

weizhouapache commented Feb 7, 2024 •

edited

codecov bot commented Feb 7, 2024 •

edited