-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zone wizard: allow only one untagged physical network with guest traffic type #8625
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8625 +/- ##
============================================
- Coverage 13.16% 13.16% -0.01%
+ Complexity 9200 9199 -1
============================================
Files 2724 2724
Lines 258101 258101
Branches 40228 40228
============================================
- Hits 33977 33970 -7
- Misses 219819 219829 +10
+ Partials 4305 4302 -3 ☔ View full report in Codecov by Sentry. |
@blueorangutan package |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8582 |
@vishesh92 |
@weizhouapache I have already added this. |
Let me add a snapshot for the same. |
ok @vishesh92 |
@vishesh92 if the error happens, will the "Fix errors" button appear and go to the step (in the screenshot) if click the button ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, needs testing (in a multi physnet env)
I am not able to reproduce an issue in which it has to return to Physical Network creation page. I didn't make a lot of changes, so it shouldn't break any existing behavior. |
@vishesh92 |
I have added a validation forcing the user to add tags to physical networks. So, can't reproduce with this scenario. |
good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
Description
This PR fixes #8279 by allowing to specify tags for physical networks and adding checks to ensure that there can be only one untagged physical network having guest traffic.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?