linstor: use relative hostname path #8633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in issue apache#8310 some older distributions don't have hostname in /usr/bin so rely on PATH resolving
13 tasks
rohityadavcloud
approved these changes
Feb 9, 2024
|
Thanks for fixing this @rp- |
|
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8633 +/- ##
=========================================
Coverage 13.16% 13.16%
Complexity 9199 9199
=========================================
Files 2724 2724
Lines 258109 258109
Branches 40228 40228
=========================================
Hits 33970 33970
Misses 219837 219837
Partials 4302 4302 ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8608 |
| @@ -88,7 +88,7 @@ private String getHostname() { | |||
| return result.trim(); | |||
| } catch (IOException | InterruptedException exc) { | |||
There was a problem hiding this comment.
Suggested change
| } catch (IOException | InterruptedException exc) { | |
| } catch (Exception exc) { |
if so, remove IOException from import.
|
tested ok, merging |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Feb 20, 2024
As described in issue apache#8310 some older distributions don't have hostname in /usr/bin so rely on PATH resolving
rp-
added a commit
to LINBIT/cloudstack
that referenced
this pull request
May 16, 2024
As described in issue apache#8310 some older distributions don't have hostname in /usr/bin so rely on PATH resolving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #8310 some older distributions don't have hostname in /usr/bin so rely on PATH resolving
Description
This PR Fixes: #8310 on 4.18 branch
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
local linstor cluster and was working before see changes in #6682