-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
list by isEncrypted #8643
list by isEncrypted #8643
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8643 +/- ##
============================================
- Coverage 30.74% 30.74% -0.01%
+ Complexity 33053 33042 -11
============================================
Files 5352 5352
Lines 374460 374485 +25
Branches 54610 54614 +4
============================================
- Hits 115123 115122 -1
- Misses 244068 244089 +21
- Partials 15269 15274 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
@DaanHoogland |
makes sense but the field doesn't exist. I'll refresh my sql-fu to get it in. |
with your PR #8647 , you need to add a line to engine/schema/src/main/resources/META-INF/db/views/cloud.volume_view.sql
then add the field in |
I thought you meant a field |
if need, you can add a method |
@DaanHoogland Can we revisit this after we merge #8321? This will probably result in conflicts with #8321. |
@blueorangutan package |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #8643 +/- ##
============================================
- Coverage 14.96% 14.96% -0.01%
- Complexity 10998 10999 +1
============================================
Files 5373 5373
Lines 469301 469320 +19
Branches 61031 57815 -3216
============================================
- Hits 70224 70219 -5
- Misses 391302 391328 +26
+ Partials 7775 7773 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Since the query uses VolumeVO now, the fix could be much simple like
|
code looks good @DaanHoogland |
66ed7a3
to
01bb5c4
Compare
We could do @weizhouapache , but as this is not touching the actual response object but only the selection criteria, it seems to be a separate issue to me. The Cmd type is not know at the time of Response creation. It goes two levels deep onto the stack in Helper classes. |
ok @DaanHoogland I just checked the volume_view, it does not have |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9673 |
@blueorangutan test |
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
[SF] Trillian test result (tid-10258)
|
01bb5c4
to
225d9e5
Compare
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9821 |
225d9e5
to
ace138e
Compare
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9846 |
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
ace138e
to
d4f99cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Tested the API and it works fine
- Create a encrypted custom disk offering
- Create a data disk with the disk offering mentioned in step 1
- attach it to a running vm
- Execute the list volume with isencyrpted parameter
(cmk) 🐱 > list volumes isencrypted=true
{
"count": 1,
"volume": [
{
"account": "admin",
"clusterid": "fe78444f-224d-442d-ac45-a476151854e2",
"clustername": "p1-c1",
"created": "2024-06-11T07:14:48+0000",
"destroyed": false,
"deviceid": 1,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"diskofferingdisplaytext": "encrypt",
"diskofferingid": "9d7cf65d-003c-4372-ba4e-af94e535cec6",
"diskofferingname": "encrypt",
"displayvolume": true,
"domain": "ROOT",
"domainid": "ee255cb8-27ba-11ef-9848-1e00210001ab",
"encryptformat": "luks",
"hasannotations": false,
"hypervisor": "KVM",
"id": "179b9925-1867-4b0f-abbc-40ebe964575e",
"isextractable": true,
"name": "DATA-3",
"path": "179b9925-1867-4b0f-abbc-40ebe964575e",
"podid": "40c6e7f0-a613-49ae-847c-3fe8c2d3623f",
"podname": "Pod1",
"provisioningtype": "thin",
"quiescevm": false,
"size": 10737418240,
"state": "Ready",
"storage": "ref-trl-6792-k-Mol8-kiran-chavala-kvm-pri1",
"storageid": "230486b2-6c8f-3338-978e-9147ba94829a",
"storagetype": "shared",
"supportsstoragesnapshot": false,
"tags": [],
"type": "DATADISK",
"virtualmachineid": "4c300cb2-d3b2-489f-841e-546e98a3021a",
"vmdisplayname": "vm1",
"vmname": "vm1",
"vmstate": "Running",
"vmtype": "User",
"zoneid": "424ee83b-ded2-428e-a8e5-8a4a1b124cb9",
"zonename": "ref-trl-6792-k-Mol8-kiran-chavala"
}
]
}
@blueorangutan test |
@kiranchavala a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
[SF] Trillian test result (tid-10410)
|
api/src/main/java/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java
Outdated
Show resolved
Hide resolved
…e/ListVolumesCmd.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9877 |
Merging this based on the reviews & test results. |
Description
This PR...
Fixes: #8635
very much a PoC on this.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?