Fixup: Optimize getRouterHealthChecksConfig method

[vishesh92]

Description

This PR optimizes the query in getRouterHealthChecksConfig by moving the state filter from for loop to the query itself.

Possibly related issues: #8055 , #8201

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

code lgtm

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8d4b4dc) 13.16% compared to head (07423d7) 13.16%.
Report is 1 commits behind head on 4.18.

Files	Patch %	Lines
...ork/router/VirtualNetworkApplianceManagerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.18    #8677      +/-   ##
============================================
- Coverage     13.16%   13.16%   -0.01%     
  Complexity     9203     9203              
============================================
  Files          2724     2724              
  Lines        258120   258122       +2     
  Branches      40231    40230       -1     
============================================
  Hits          33989    33989              
- Misses       219823   219825       +2     
  Partials       4308     4308              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8711

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[sureshanaparti]

clgtm

[blueorangutan]

[SF] Trillian test result (tid-9302)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39247 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8677-t9302-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File