-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console proxy client sleep more generic #8694
console proxy client sleep more generic #8694
Conversation
@weizhouapache @nvazquez , this is purely based on the description in #8692. Any advice on verification? |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java
Outdated
Show resolved
Hide resolved
…roxy/ConsoleProxyNoVncClient.java Co-authored-by: Wei Zhou <weizhou@apache.org>
Packaging result [SF]: ✖️ el7 ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 8747 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8694 +/- ##
=========================================
Coverage 13.16% 13.16%
Complexity 9203 9203
=========================================
Files 2724 2724
Lines 258122 258122
Branches 40230 40230
=========================================
Hits 33989 33989
Misses 219825 219825
Partials 4308 4308 ☔ View full report in Codecov by Sentry. |
Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6211 |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8748 |
@blueorangutan test alma9 kvm-alma9 |
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
A couple questions, if you don't mind:
|
[SF] Trillian test result (tid-9319)
|
valid questions @kohrar , sounds like you are arguing for configurability. This is the simplest solution to the issue in your initial ticket. What you are asking now is a bigger (functional) change however. I would prefer to discuss and implement that separately. |
* Make wait in the noVNC console proxy client more generic * Update services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java Co-authored-by: Wei Zhou <weizhou@apache.org> --------- Co-authored-by: Wei Zhou <weizhou@apache.org>
Description
This PR...
Fixes: #8692
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?