-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CKS: fix /opt/bin/deploy-cloudstack-secret in CKS control nodes #8697
CKS: fix /opt/bin/deploy-cloudstack-secret in CKS control nodes #8697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8697 +/- ##
=========================================
Coverage 13.16% 13.16%
Complexity 9203 9203
=========================================
Files 2724 2724
Lines 258122 258122
Branches 40230 40230
=========================================
Hits 33989 33989
Misses 219825 219825
Partials 4308 4308 ☔ View full report in Codecov by Sentry. |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8758 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
this is a help string update, 2 lgtm, gha passed; merging |
* 4.18: Storage plugin support to check if volume on datastore requires access for migration (apache#8655) CKS: fix /opt/bin/deploy-cloudstack-secret in CKS control nodes (apache#8697)
Description
This PR fixes the typos in deploy-cloudstack-secret script.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?