Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Allow detach ISO from instance toolbar when ISO is attached #8716

Merged

Conversation

sureshanaparti
Copy link
Contributor

Description

This PR allows detach ISO from instance toolbar when ISO is attached.

Fixes #8711

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested attach & detach ISO from instance toolbar.

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.18.2.0 milestone Feb 28, 2024
@sureshanaparti
Copy link
Contributor Author

@blueorangutan ui

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (4e34e6b) to head (2e64496).
Report is 2 commits behind head on 4.18.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.18    #8716   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
  Complexity     9203     9203           
=========================================
  Files          2724     2724           
  Lines        258130   258130           
  Branches      40232    40232           
=========================================
  Hits          33989    33989           
  Misses       219833   219833           
  Partials       4308     4308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sureshanaparti
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8716 (QA-JID-292)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested in qa

Copy link
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM, also tested in QA

@DaanHoogland DaanHoogland merged commit 0b080cf into apache:4.18 Mar 4, 2024
26 checks passed
@DaanHoogland DaanHoogland deleted the ui-show-detach-iso-in-instance-toolbar branch March 4, 2024 08:43
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants